Collapse option not working for the the BO category tree

[crezzur]

Questions	Answers
Branch?	1.7.7.x
Description?	Resolve issue "collapse" option not working for the the BO category tree (old theme) Affected pages: Faceted search, other pages and modules which use the old theme tree version
Type?	bug fix
Category?	BO
BC breaks?
Deprecations?
Fixed ticket?	Fixes #23558.
How to test?	Displays an error when closing a (sub)category folder in the category tree.
Possible impacts?	category tree in module Faceted search, other pages and modules which uses the old theme category tree.

---

This change is 

[prestonBot]

Hello @crezzur!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

[NeOMakinG]

I asked a question only on one this, but every $(this) scope looks strange to me

[NeOMakinG]

Tested it and every changed line was using wrong scoped reference, LGTM to me ;)

[khouloudbelguith]

Hi @crezzur,

Thanks for your fix.
This PR fixes a regression in PS1.7.7, you need to target the 1.7.7.x branch.

Thank you!

[Progi1984]

@crezzur No your are targeting develop branch and not the 1.7.7.x branch

[Progi1984]

@crezzur I think you misunderstood me : your PR targets the develop branch :

The base branch was changed.

[NeOMakinG]

@crezzur I think you need to change the target branch to 1.7.7.x, and then rebase your branch on the 1.7.7.x branch, if the rebase is too hard, we can just open a new PR or cherry pick the commit on a new PR

[NeOMakinG]

@NeOMakinG Did i do it correct now?

You just changed the base branch, you need to rebase it into 1.7.7.x now

[khouloudbelguith]

Hi @crezzur,

The first issue is fixed but the second problem still exists.
Steps to reproduce the issue:

1. Go to BO > Shop Parameters > General page
2. Enable Multistore context
3. Go to BO > Advanced Parameters > Multistore page
4. Click on "Add new shop"
5. In the "Associated categories" section, click on Collapse All
6. Click on Check All
7. Click on Expand All
8. Try to close a folder
9. See error: Cannot be closed

I attached a screen record
https://drive.google.com/file/d/1XfrDGN6BgR_LmCS8ALnpO0fDeUEVR7VO/view?usp=sharing

Thank you!

[crezzur]

@khouloudbelguith
The error is showing instantly when you click on the expand all button. The reason it is displayed in the Add shop treeview only is because this treeview has the search option activated.

The error is caused by the function call organizeTree(); (tree.js line 218).
Looking into this function it looks like its a dead part of code.

inside the function organizeTree() a call to the function getCategoryById() is made. Looking into the function getCategoryById() the HTML attribute name="id_parent" is searched.

Searching into the whole folder STORE\BACKFOFFICE\themes\default\ and more specific STORE\BACKFOFFICE\themes\default\template\helpers\tree\ for the HTML attribute name="id_parent" returns negative.

concluding this i am guessing the functions organizeTree() and getCategoryById() are leftovers from something what is already removed. If you come to the same conclusion i will add a pull request to remove those functions.

[khouloudbelguith]

Hi @crezzur,

Thanks for your feedback.
So this issue of creating a shop will be fixed in another PR?

Thank you!

[crezzur]

@khouloudbelguith added the changes to this pull request.

[khouloudbelguith]

Hi @crezzur,

It is ok ✔️
https://drive.google.com/file/d/1IDkA6nqb1P4OPc22qNTl32c-QXBYcRYD/view?usp=sharing

Thank you!

[prestonBot]

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

[prestonBot]

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)