-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update state.xml - Distrito Federal changed to Ciudad de México #23828
Conversation
Hello @rickygzz! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the change but IMHO this must be validated by @PrestaShop/product-team
Maybe you will have to create an issue to open the discussion if there is one
Looks good to me ! :) |
Hello @rickygzz ! With your PR, the state is now OK (Ciudad de México) : So it's QA ✔️ ! Thanks for your PR :) |
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
Thanks @rickygzz |
Contribution merged, congratulations! Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-) |
install-dev/data/xml/state.xml
which is used when you first install the prestashop on the server. It is used to create the the database tableps_states
with the states values for all the countries (when available). I am just suggesting an update to this file, since it has been several years since Distrito Federal changed its name to Ciudad de México.Changed:
name tag Distrito Federal to Ciudad de México
and its state tag properties id= and iso_code= to "CMX" according to its iso3166-2 code.
On 29 January 2016, Mexico City ceased to be the Federal District (Spanish: Distrito Federal or D.F.), and was officially renamed "Ciudad de México" (or "CDMX")
Source:
https://www.iso.org/obp/ui/#iso:code:3166:MX
https://en.wikipedia.org/wiki/Mexico_City#20th_century_to_present
This change is