Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state.xml - Distrito Federal changed to Ciudad de México #23828

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

rickygzz
Copy link
Contributor

@rickygzz rickygzz commented Mar 30, 2021

Questions Answers
Branch? develop
Description? There is a file named install-dev/data/xml/state.xml which is used when you first install the prestashop on the server. It is used to create the the database table ps_states with the states values for all the countries (when available). I am just suggesting an update to this file, since it has been several years since Distrito Federal changed its name to Ciudad de México.
Type? improvement
Category? LO
BC breaks? no
Deprecations? no
Fixed ticket? Fixe #23860
How to test? It just updates a city name in Mexico.
Possible impacts? Since everything is linked to the state_id and not to the state.name, I dont think it will impact anything.

Changed:

-    <state id="DIF" id_country="MX" id_zone="North_America" iso_code="DIF" tax_behavior="0" active="1">
-      <name>Distrito Federal</name> 
+    <state id="CMX" id_country="MX" id_zone="North_America" iso_code="CMX" tax_behavior="0" active="1">
+      <name>Ciudad de México</name>

name tag Distrito Federal to Ciudad de México
and its state tag properties id= and iso_code= to "CMX" according to its iso3166-2 code.

On 29 January 2016, Mexico City ceased to be the Federal District (Spanish: Distrito Federal or D.F.), and was officially renamed "Ciudad de México" (or "CDMX")

Source:
https://www.iso.org/obp/ui/#iso:code:3166:MX
https://en.wikipedia.org/wiki/Mexico_City#20th_century_to_present


This change is Reviewable

@rickygzz rickygzz requested a review from a team as a code owner March 30, 2021 23:28
@prestonBot
Copy link
Collaborator

Hello @rickygzz!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Mar 30, 2021
@rickygzz rickygzz mentioned this pull request Mar 30, 2021
Copy link
Contributor

@sowbiba sowbiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the change but IMHO this must be validated by @PrestaShop/product-team

Maybe you will have to create an issue to open the discussion if there is one

@eternoendless eternoendless added the Waiting for PM Status: action required, waiting for product feedback label Apr 1, 2021
@MatShir MatShir added PM ✔️ Status: check done, behavior approved and removed Waiting for PM Status: action required, waiting for product feedback labels Apr 1, 2021
@MatShir
Copy link
Contributor

MatShir commented Apr 1, 2021

Looks good to me ! :)

@sowbiba sowbiba added the Waiting for QA Status: action required, waiting for test feedback label Apr 1, 2021
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Apr 1, 2021
@Robin-Fischer-PS
Copy link
Contributor

Hello @rickygzz !

With your PR, the state is now OK (Ciudad de México) :

pr23828 mexico ok

So it's QA ✔️ !

Thanks for your PR :)

@Robin-Fischer-PS Robin-Fischer-PS added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 1, 2021
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@PululuK
Copy link
Member

PululuK commented Apr 1, 2021

Thanks @rickygzz

@PululuK PululuK merged commit f04b69c into PrestaShop:develop Apr 1, 2021
@prestonBot
Copy link
Collaborator

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

@PululuK PululuK added this to the 1.7.8.0 milestone Apr 1, 2021
@PululuK PululuK linked an issue Apr 1, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement PM ✔️ Status: check done, behavior approved QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the name of Mexico City
8 participants