Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of GH jobs, run one PHPUnit job per PHP version #23954

Merged
merged 2 commits into from May 11, 2021
Merged

Reduce number of GH jobs, run one PHPUnit job per PHP version #23954

merged 2 commits into from May 11, 2021

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Apr 8, 2021 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? It does not make much sense to run extra job for phpunit tests that does not require DB. They are fast, they require only 5 seconds to complete. This should reduce PRs jobs backlog.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? GH CI must pass
Possible impacts? no

This change is Reviewable

@mvorisek mvorisek requested a review from a team as a code owner April 8, 2021 23:18
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Apr 8, 2021
@Progi1984
Copy link
Contributor

I disapprove this PR. Launching PHPUnit on each versions of PHP permits to detect some behavior due to PHP version.

@mvorisek
Copy link
Contributor Author

mvorisek commented Apr 9, 2021

I disapprove this PR. Launching PHPUnit on each versions of PHP permits to detect some behavior due to PHP version.

@Progi1984 please rereview the changes, I did not change any functionality, all original combinations are tested :)

atomiix
atomiix previously approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@atomiix atomiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me!

Progi1984
Progi1984 reviewed Apr 14, 2021
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small feedback

@mvorisek
Copy link
Contributor Author

@atomiix @Progi1984 please reapprove with the updated ubuntu-latest

@atomiix
Copy link
Contributor

atomiix commented Apr 22, 2021 •
edited

@mvorisek tests are red.

@mvorisek mvorisek mentioned this pull request Apr 22, 2021
Closed
@mvorisek
Copy link
Contributor Author

mvorisek commented May 7, 2021

@mvorisek tests are red.

fixed, reverted ubuntu-latest - ubuntu-latest does not contain mysqldump binary

@eternoendless eternoendless merged commit 2232628 into PrestaShop:develop May 11, 2021
@prestonBot
Copy link
Collaborator

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

@eternoendless
Copy link
Member

Thank you @mvorisek

@Progi1984 Progi1984 added this to the 1.7.9.0 milestone May 11, 2021
@mvorisek mvorisek deleted the reduce_ci_jobs branch May 11, 2021 08:02
@mvorisek
Copy link
Contributor Author

image

something needs to be updated in the CI system to not show/expect these jobs in PR checks

@matks matks mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@atomiix atomiix atomiix approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mvorisek @Progi1984 @atomiix @prestonBot @eternoendless