Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register translation wordings for Feature Flag #24045

Merged
merged 1 commit into from Apr 14, 2021

Conversation

matks
Copy link
Contributor

@matks matks commented Apr 14, 2021

Questions Answers
Branch? develop
Description? Register the wordings for Feature Flag.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #24000
How to test? See below
Possible impacts? ~

How to test

  1. Install PS using this branch with FRENCH language
  2. Run the following SQL script to load the feature flag data
INSERT INTO `ps_feature_flag` (`name`, `state`, `label_wording`, `label_domain`, `description_wording`, `description_domain`)
VALUES
   ('product_page_v2', 0, 'Experimental product page', 'Admin.Advparameters.Feature', 'This page is a work in progress. It includes new combination management features and other features under development (virtual products, packs, etc.)', 'Admin.Advparameters.Help');
  1. Open the Back Office using FRENCH language
  2. Open Configure > Adv Parameters > Experimental Feature: wordings are not translated

Capture d’écran 2021-04-14 à 15 40 21

  1. Open International > Translations Page and follow "Translate Back Office wordings" menu
  2. You can find the 2 wordings for Feature flag in
  • Admin > AdvParameter > Feature for the flag name Experimental product page
  • Admin > AdvParameter > Help for the help message This page is a work in progress. It includes new combination management features and other features under development (virtual products, packs, etc.)
  1. Using the translation interface you can translate the 2 wordings

Capture d’écran 2021-04-14 à 15 46 31

  1. Save your translations, go back to Configure > Adv Parameters > Experimental Feature and see translated wordings

Capture d’écran 2021-04-14 à 15 45 09


This change is Reviewable

@matks matks requested a review from a team as a code owner April 14, 2021 13:46
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Apr 14, 2021
@matks matks added Must-have Kanban prioritization: issue must be included in next version and removed Improvement Type: Improvement labels Apr 14, 2021
@prestonBot prestonBot added the Improvement Type: Improvement label Apr 14, 2021
@prestonBot
Copy link
Collaborator

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Apr 14, 2021
@matks matks added Must-have Kanban prioritization: issue must be included in next version and removed Improvement Type: Improvement Must-have Kanban prioritization: issue must be included in next version Waiting for wording Status: action required, waiting for wording labels Apr 14, 2021
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Apr 14, 2021
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Apr 14, 2021
@eternoendless eternoendless added the QA ✔️ Status: check done, code approved label Apr 14, 2021
@eternoendless
Copy link
Member

IMO this doesn't require QA because there is no functional change

@Progi1984
Copy link
Contributor

Ping @PrestaShop/qa-functional for validation.

@sarahdib
Copy link
Contributor

sarahdib commented Apr 14, 2021

@Progi1984 this can be tested by a QA functional :) @Robin-Fischer-PS is already on it

@sarahdib sarahdib added Waiting for QA Status: action required, waiting for test feedback and removed QA ✔️ Status: check done, code approved labels Apr 14, 2021
@Robin-Fischer-PS
Copy link
Contributor

Hi @matks

Translation is OK on the new page :

pr 24045 - translation OK

Thanks !

@Robin-Fischer-PS Robin-Fischer-PS added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 14, 2021
@matks matks removed the Waiting for wording Status: action required, waiting for wording label Apr 14, 2021
@matks matks merged commit e691f52 into PrestaShop:develop Apr 14, 2021
@matks matks deleted the translate-ff branch April 14, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Must-have Kanban prioritization: issue must be included in next version QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add support for experimental features] Make sure Handle Product Page V2 flag is translatable
8 participants