Replace "on sale" flag by "price drop"

[marionf]

Questions	Answers
Branch?	develop
Description?	Replace "on sale" flag by "price drop"
Type?	improvement
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #19145
How to test?	Verify the wording in the BO product page > Princing tab, it should be "Display the "Price drop!" flag on the product page, and on product listings.". Check the box and verify the flag on the product page and product listing, it should be "Price drop!"
Possible impacts?	nothing

---

This change is 

[prestonBot]

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

• Admin.Catalog.Feature
  • Display the "Price drop!" flag on the product page, and on product listings.
• Shop.Theme.Catalog
  • Price drop!

(Note: this is an automated message, but answering it will reach a real human)

[Progi1984]

@marionf Could you fix Integration tests : https://github.com/PrestaShop/PrestaShop/pull/24109/checks?check_run_id=2379725813#step:14:39 ?

[Progi1984]

@marionf Great job ;)

[sarahdib]

@marionf it's ok 👍🏻

[prestonBot]

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

[Progi1984]

Thanks @marionf & @sarahdib

[kpodemski]

@PrestaShop/product-team @PrestaShop/prestashop-maintainers

IMO It's wrong way of fixing #19145. #19145 is about page title, not "On sale" as overall in the system.

It would be confusing for people after all these years to change this flag.

[marionf]

Hi @kpodemski

We have identified that the "on sale" flag is confusing, it can be translated in different ways according to the language.
Some people use it to put forward discounted products, while some use it to put forward end of stock products without discount.
This why we change it for "price drop" to put forward discounted products.

Also, we are going to use a new "Last chance" flag and page to put forward end of stock products without discount.

Anyway, these flags can always be translated by merchants through the BO if needed.

[Hlavtox]

@kpodemski Exactly.

I want to see the first issue where people say: I checked "Prices drop" but the product is not displayed on prices-drop page, why is that?

Incorrect title on prices-drop controller was successfully fixed here #23858 and it should have ended by this.