Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force All shops context for Experimental Features BO page #24128

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Force All shops context for Experimental Features BO page #24128

merged 1 commit into from
Apr 27, 2021

Conversation

matks
Copy link
Contributor

@matks matks commented Apr 20, 2021 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? Force All shops context for Experimental Features BO page
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #24059
How to test? See #24059
Possible impacts? The Experimental Feature controller now forces the All Shops context.

This change is Reviewable

@matks matks requested a review from a team as a code owner April 20, 2021 14:23
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Apr 20, 2021
@matks matks force-pushed the force-all-shops-experimental-feature-page branch from 54a4b87 to bd596e9 Compare April 20, 2021 14:52
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Apr 20, 2021
@matks matks force-pushed the force-all-shops-experimental-feature-page branch from bd596e9 to 2a45f6b Compare April 20, 2021 14:53
Progi1984
Progi1984 previously approved these changes Apr 20, 2021
View reviewed changes
@Julievrz Julievrz added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Apr 21, 2021
Julievrz
Julievrz previously approved these changes Apr 21, 2021
View reviewed changes
@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Apr 21, 2021
PierreRambaud
PierreRambaud reviewed Apr 21, 2021
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have to target the 1.7.8.x branch?

@Progi1984 Progi1984 removed the Waiting for QA Status: action required, waiting for test feedback label Apr 22, 2021
@matks matks changed the base branch from develop to 1.7.8.x April 22, 2021 08:46
@matks matks dismissed stale reviews from Julievrz and Progi1984 April 22, 2021 08:46

The base branch was changed.

@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Apr 22, 2021
@matks matks mentioned this pull request Apr 23, 2021
Closed
@Robin-Fischer-PS Robin-Fischer-PS added 1.7.8.x Branch and removed develop Branch labels Apr 23, 2021
@khouloudbelguith khouloudbelguith self-assigned this Apr 26, 2021
@khouloudbelguith
Copy link
Contributor

Hi @matks,

I have an issue following these steps:

  1. Go to BO > Shop Parameters > General page
  2. Enable Multidtore context
  3. Go to BO > Advanced Parameters > Multistore page
  4. Create a new shop
  5. Go to BO > Advanced Parameters > Experimental Features page => ok
    image
  6. Click on "All shops"
    image
  7. See error: the Note is not displayed anymore => NOK
    image

Thank you!

@khouloudbelguith khouloudbelguith added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 26, 2021
@matks
Copy link
Contributor Author

matks commented Apr 26, 2021

Hi @khouloudbelguith

See error: the Note is not displayed anymore => NOK

This is expected 😉 . If user has selected "All Shops context", we do not switch the context for him and consequently we do not display the message.

The note says "Note that this page is available in all shops context only, this is why your context has just switched." . If user already has All Shops context ; we do not switch the context ; we do not display the note.

See also the GitHub issue #24059

When BO user visits the Experimental Features Back Office page, if his shop context is not "All shops" we force the shop context to "All shops".

@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Apr 26, 2021
@matks matks removed the Waiting for author Status: action required, waiting for author feedback label Apr 26, 2021
@khouloudbelguith
Copy link
Contributor

Hi @matks,

It is ok ✔️
https://drive.google.com/file/d/1a1rc5QoDnqH2JYwATydWzpMpOPHWIOhZ/view?usp=sharing

Thank you!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 27, 2021
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@khouloudbelguith khouloudbelguith added this to the 1.7.8.0 milestone Apr 27, 2021
@Progi1984 Progi1984 merged commit 34dca37 into PrestaShop:1.7.8.x Apr 27, 2021
@Progi1984
Copy link
Contributor

Thanks @matks & @khouloudbelguith

@Progi1984 Progi1984 mentioned this pull request Apr 27, 2021
Closed
@Progi1984 Progi1984 deleted the force-all-shops-experimental-feature-page branch April 28, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@Julievrz Julievrz Julievrz left review comments

@PierreRambaud PierreRambaud Awaiting requested review from PierreRambaud

Assignees

@khouloudbelguith khouloudbelguith

Labels
1.7.8.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Force All Shops context for Experimental Features Back Office page
8 participants
@matks @khouloudbelguith @prestonBot @Progi1984 @PierreRambaud @matthieu-rolland @Julievrz @Robin-Fischer-PS