Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mispelled word in AdminController #24785

Merged
merged 1 commit into from Jun 3, 2021

Conversation

prestaforum
Copy link
Contributor

@prestaforum prestaforum commented Jun 3, 2021

Questions Answers
Branch? develop
Description? Fix mispelled word in AdminController
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?
Possible impacts?

This change is Reviewable

@prestaforum prestaforum requested a review from a team as a code owner June 3, 2021 09:18
@prestonBot
Copy link
Collaborator

Hello @prestaforum!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jun 3, 2021
@PierreRambaud PierreRambaud merged commit c25ec48 into PrestaShop:develop Jun 3, 2021
@prestonBot
Copy link
Collaborator

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

@PierreRambaud
Copy link
Contributor

thank you @prestaforum

@PierreRambaud PierreRambaud added this to the 1.7.9.0 milestone Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants