Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix js error when adding voucher in create order #24794

Merged
merged 3 commits into from Jun 9, 2021
Merged

Fix js error when adding voucher in create order #24794

merged 3 commits into from Jun 9, 2021

Conversation

atomiix
Copy link
Contributor

@atomiix atomiix commented Jun 3, 2021 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.8.x
Description? Some JS that is executed a first time when the page load, is executed a second time when the ajax request is performed when adding a cart rule. The JS executed contains variable assignations, some of them were const or let and so couldn't be re-assigned the second time.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #24556
How to test? Please see #24556
Possible impacts?

This change is Reviewable

@atomiix atomiix requested a review from a team as a code owner June 3, 2021 15:07
@prestonBot prestonBot added 1.7.8.x Branch Bug fix Type: Bug fix labels Jun 3, 2021
@atomiix atomiix linked an issue Jun 3, 2021 that may be closed by this pull request
BO - Add new Order page - an error is displayed in the console when adding a voucher #24556
Closed
@atomiix atomiix added this to the 1.7.8.0 milestone Jun 3, 2021
matthieu-rolland
matthieu-rolland reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one feedback 👍

admin-dev/themes/default/template/controllers/cart_rules/form.js Outdated Show resolved Hide resolved
kpodemski
kpodemski previously approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is legacy page it LGTM, we'll probably have better quality of JS when this page would be migrated to Symfony :)

@atomiix @PierreRambaud
Update classes/controller/AdminController.php
a35ca53 
Co-authored-by: GoT <PierreRambaud@users.noreply.github.com>
matthieu-rolland
matthieu-rolland approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Jun 4, 2021
@SD1982 SD1982 self-assigned this Jun 9, 2021
@SD1982
Copy link
Contributor

SD1982 commented Jun 9, 2021

LGTM !! Thanks @atomiix !!

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 9, 2021
@Progi1984 Progi1984 merged commit 0538e15 into PrestaShop:1.7.8.x Jun 9, 2021
@Progi1984
Copy link
Contributor

Thanks @atomiix & @SD1982

@Progi1984 Progi1984 mentioned this pull request Jun 9, 2021
Closed
@atomiix atomiix deleted the fix/24556 branch June 9, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@kpodemski kpodemski Awaiting requested review from kpodemski

Assignees

@SD1982 SD1982

Labels
1.7.8.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

BO - Add new Order page - an error is displayed in the console when adding a voucher
8 participants
@atomiix @SD1982 @Progi1984 @PierreRambaud @matthieu-rolland @kpodemski @NeOMakinG @prestonBot