Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "chosen" to filter available fields on Import page #24803

Merged
merged 1 commit into from Jun 10, 2021
Merged

Add "chosen" to filter available fields on Import page #24803

merged 1 commit into from Jun 10, 2021

Conversation

kpodemski
Copy link
Contributor

@kpodemski kpodemski commented Jun 3, 2021 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? Little one liner but IMO huge UX improvement
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #24802 .
How to test? Try to import something and map available fields to column
Possible impacts? n/a

This change is Reviewable

@kpodemski kpodemski requested a review from a team as a code owner June 3, 2021 22:23
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jun 3, 2021
PululuK
PululuK approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@PululuK PululuK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah !

@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jun 4, 2021
@Progi1984 Progi1984 added this to the 1.7.9.0 milestone Jun 8, 2021
@florine2623 florine2623 self-assigned this Jun 10, 2021
@florine2623 florine2623 changed the title Add chosen to filter available fields on Import page Add "chosen" to filter available fields on Import page Jun 10, 2021
@florine2623
Copy link
Contributor

LGTM

Thanks @kpodemski !

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 10, 2021
@Progi1984 Progi1984 merged commit 6e01288 into PrestaShop:develop Jun 10, 2021
@Progi1984
Copy link
Contributor

Thanks @kpodemski & @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@PululuK PululuK PululuK approved these changes

Assignees

@florine2623 florine2623

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Allow to filter available fields on import page
6 participants
@kpodemski @florine2623 @Progi1984 @PierreRambaud @PululuK @prestonBot