Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refacto stock page using TypeScript #25186

Merged
merged 3 commits into from Jul 30, 2021
Merged

Refacto stock page using TypeScript #25186

merged 3 commits into from Jul 30, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Jun 30, 2021 •
edited

Questions Answers
Branch? develop
Description? Stock page wasn't migrated to TypeScript, let's do it!
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? Go on Stock page, test it, it should work as before (Sorry <3)
Possible impacts? Stock page

This change is Reviewable

@NeOMakinG NeOMakinG added the WIP Status: Work In Progress label Jun 30, 2021
@prestonBot prestonBot added the Bug fix Type: Bug fix label Jun 30, 2021
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • The category should be one of these: BO, CO, FO, IN, LO, ME, PM, TE or WS (Read explanation)

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

(Note: this is an automated message, but answering it will reach a real human)

@NeOMakinG NeOMakinG added this to the 1.7.9.0 milestone Jul 1, 2021
@NeOMakinG NeOMakinG removed the WIP Status: Work In Progress label Jul 1, 2021
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jul 1, 2021
@NeOMakinG NeOMakinG changed the title [WIP] Begin to refacto vue components into typescript Refacto stock page using TypeScript Jul 1, 2021
@NeOMakinG NeOMakinG marked this pull request as ready for review July 1, 2021 14:27
@NeOMakinG NeOMakinG requested a review from a team as a code owner July 1, 2021 14:27
matks
matks approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no issues in code but I am not a good frontend developer

The PR changes more things than just the Stock page also 😉

@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jul 22, 2021
@Progi1984 Progi1984 closed this Jul 30, 2021
@Progi1984 Progi1984 reopened this Jul 30, 2021
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 30, 2021
@Progi1984 Progi1984 merged commit afd69ca into PrestaShop:develop Jul 30, 2021
@Progi1984
Copy link
Contributor

Thanks @NeOMakinG & @sarahdib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
Bug fix Type: Bug fix develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@NeOMakinG @prestonBot @Progi1984 @PierreRambaud @matks @sarahdib