Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests - Refacto monitoring tests #25250

Merged
merged 11 commits into from Jul 19, 2021
Merged

Functional tests - Refacto monitoring tests #25250

merged 11 commits into from Jul 19, 2021

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Jul 6, 2021 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.8.x
Description? Refacto monitoring tests
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? no need
Possible impacts? no

This change is Reviewable

@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner July 6, 2021 10:23
@prestonBot prestonBot added 1.7.8.x Branch Refactoring Type: Refactoring labels Jul 6, 2021
@nesrineabdmouleh nesrineabdmouleh added E2E Tests TE Category: Tests labels Jul 6, 2021
@nesrineabdmouleh nesrineabdmouleh added this to the 1.7.8.0 milestone Jul 6, 2021
@nesrineabdmouleh nesrineabdmouleh requested a review from a team July 6, 2021 10:23
@boubkerbribri boubkerbribri added the QA ✔️ Status: check done, code approved label Jul 7, 2021
boubkerbribri
boubkerbribri previously requested changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@boubkerbribri boubkerbribri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAIT FOR 1.7.8.0 RELEASE

@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Jul 9, 2021
@matks matks removed the Waiting for author Status: action required, waiting for author feedback label Jul 19, 2021
@matks
Copy link
Contributor

matks commented Jul 19, 2021

@boubkerbribri Robin has defined the scope of changes the QA team want to embed inside 1.7.8.0 RC1 build 2. This PR is inside the list.

@matks
Copy link
Contributor

matks commented Jul 19, 2021

Thank you @nesrineabdmouleh

@matks matks merged commit 822c4f9 into PrestaShop:1.7.8.x Jul 19, 2021
@nesrineabdmouleh nesrineabdmouleh deleted the refactoMonitoring branch April 6, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@boubkerbribri boubkerbribri boubkerbribri left review comments

Assignees
No one assigned
Labels
1.7.8.x Branch E2E Tests QA ✔️ Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nesrineabdmouleh @matks @NeOMakinG @boubkerbribri @Progi1984 @prestonBot