Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching playwright browsers on github workflows #25333

Merged
merged 3 commits into from Jul 13, 2021
Merged

Caching playwright browsers on github workflows #25333

merged 3 commits into from Jul 13, 2021

Conversation

boubkerbribri
Copy link
Contributor

@boubkerbribri boubkerbribri commented Jul 13, 2021 •
edited

Questions Answers
Branch? 1.7.8.x
Description? Caching playwright browsers
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? #25330
How to test? See if browsers are downloaded if GA
Possible impacts? none

This change is Reviewable

@prestonBot prestonBot added 1.7.8.x Branch Refactoring Type: Refactoring labels Jul 13, 2021
PierreRambaud
PierreRambaud previously approved these changes Jul 13, 2021
View reviewed changes
@matks matks marked this pull request as ready for review July 13, 2021 12:30
@matks matks requested a review from a team as a code owner July 13, 2021 12:30
matks
matks previously approved these changes Jul 13, 2021
View reviewed changes
@boubkerbribri boubkerbribri dismissed stale reviews from matks and PierreRambaud via 6c8d1af July 13, 2021 12:30
@boubkerbribri boubkerbribri changed the title TEST - Caching playwright browsers Caching playwright browsers on github workflows Jul 13, 2021
@boubkerbribri boubkerbribri added E2E Tests TE Category: Tests labels Jul 13, 2021
@matks matks merged commit 21278bf into PrestaShop:1.7.8.x Jul 13, 2021
@matks
Copy link
Contributor

matks commented Jul 13, 2021

Thank you @boubkerbribri

@boubkerbribri boubkerbribri deleted the caching-browsers branch July 13, 2021 14:00
@matks matks mentioned this pull request Jul 13, 2021
Closed
@sowbiba sowbiba added this to the 1.7.8.0 milestone Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
1.7.8.x Branch E2E Tests Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@boubkerbribri @matks @PierreRambaud @sowbiba @prestonBot