Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BO - Customer View page - Added alert when removing a voucher #25439

Merged
merged 1 commit into from Jul 30, 2021
Merged

BO - Customer View page - Added alert when removing a voucher #25439

merged 1 commit into from Jul 30, 2021

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Jul 27, 2021 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? BO - Customer View page - Added alert when removing a voucher
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #18841
How to test? Cf #18841

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner July 27, 2021 13:11
@Progi1984 Progi1984 added this to the 8.0.0 milestone Jul 27, 2021
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix Waiting for wording Status: action required, waiting for wording labels Jul 27, 2021
matthieu-rolland
matthieu-rolland approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (let's wait for wording validation before QA)

@Julievrz Julievrz added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Jul 28, 2021
Julievrz
Julievrz approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@Julievrz Julievrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording ✔️

@atomiix atomiix added the Waiting for QA Status: action required, waiting for test feedback label Jul 29, 2021
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 29, 2021
@Progi1984 Progi1984 merged commit 8d0531c into PrestaShop:develop Jul 30, 2021
@Progi1984 Progi1984 deleted the issue18841 branch July 30, 2021 07:09
@Progi1984
Copy link
Contributor Author

Thanks @sarahdib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@atomiix atomiix atomiix approved these changes

@Julievrz Julievrz Julievrz approved these changes

Assignees
No one assigned
Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

BO - Customer View page - there is no green alert after deleting a voucher
6 participants
@Progi1984 @matthieu-rolland @atomiix @Julievrz @sarahdib @prestonBot