Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix option selection issue in order creation page #25465

Merged
merged 2 commits into from Aug 7, 2021

Conversation

matthieu-rolland
Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Jul 29, 2021

Questions Answers
Branch? develop
Description? By default all options in the address selectors had the selected attribute set to empty, which would still select the element in the browser, so in the end all options were selected.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #25437
How to test? See issue #25437
Possible impacts? none other than what it's fixing

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from a team as a code owner July 29, 2021 16:10
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Jul 29, 2021
@matthieu-rolland matthieu-rolland changed the title fix option selection issue in order page fix option selection issue in order creation page Jul 29, 2021
@matks matks changed the title fix option selection issue in order creation page Fix option selection issue in order creation page Aug 2, 2021
@Progi1984 Progi1984 added this to the 8.0.0 milestone Aug 3, 2021
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Aug 3, 2021
@khouloudbelguith khouloudbelguith self-assigned this Aug 6, 2021
@khouloudbelguith
Copy link
Contributor

Hi @matthieu-rolland,

It is ok ✔️

  • I tried with a new customer
  • I tried with old customer
  • I tried with guest

https://drive.google.com/file/d/1f8zuzbaCjYFWxQd-ZnLgm-TpIHQ0sgIL/view?usp=sharing

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Aug 6, 2021
@Progi1984 Progi1984 merged commit 2592229 into PrestaShop:develop Aug 7, 2021
@Progi1984
Copy link
Contributor

Thanks @matthieu-rolland & @khouloudbelguith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BO] Create Order - switch the address Delivery/Invoice, it display the wrong Invoice/Delivery address
6 participants