Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "modules" directory inside "var" for data #25702

Merged
merged 1 commit into from Aug 26, 2021
Merged

Create "modules" directory inside "var" for data #25702

merged 1 commit into from Aug 26, 2021

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Aug 25, 2021

Questions Answers
Branch? develop
Description? We should have a directory where modules can store their files instead of continue putting them inside the modules directory.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? No need QA.
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner August 25, 2021 13:05
@prestonBot prestonBot added the develop Branch label Aug 25, 2021
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@Progi1984 Progi1984 added this to the 8.0.0 milestone Aug 26, 2021
@Progi1984 Progi1984 merged commit 5b2108c into PrestaShop:develop Aug 26, 2021
@Progi1984
Copy link
Contributor

Thanks @PierreRambaud

@Progi1984 Progi1984 deleted the feature/var-modules branch May 30, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants