Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Symfony 4.4.30 #25781

Merged
merged 1 commit into from Sep 8, 2021
Merged

Upgrade to Symfony 4.4.30 #25781

merged 1 commit into from Sep 8, 2021

Conversation

matks
Copy link
Contributor

@matks matks commented Sep 3, 2021

Questions Answers
Branch? develop
Description? Upgrade to Symfony from 4.4.25 to 4.4.30
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? CI shines
Possible impacts? There is nothing impactful in the Changelog so it seems to be fine.

This change is Reviewable

@matks matks requested a review from a team as a code owner September 3, 2021 08:58
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 3, 2021
@PierreRambaud PierreRambaud added this to the 8.0.0 milestone Sep 6, 2021
@atomiix atomiix merged commit c4a2292 into PrestaShop:develop Sep 8, 2021
@atomiix
Copy link
Contributor

atomiix commented Sep 8, 2021

Thanks @matks

@matks matks deleted the update-sf-4430 branch December 13, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants