Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update every package-lock with npm 7 #26021

Merged
merged 2 commits into from Oct 27, 2021
Merged

Update every package-lock with npm 7 #26021

merged 2 commits into from Oct 27, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Sep 28, 2021 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? Every package-lock are outdated and built with npm 6 while we now use node 14 and npm 7
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? Just build every front-end folders, it's testable by a dev
Possible impacts? every npm builds

This change is Reviewable

@NeOMakinG NeOMakinG added this to the 8.0.0 milestone Sep 28, 2021
@NeOMakinG NeOMakinG requested a review from a team as a code owner September 28, 2021 12:33
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 28, 2021
matks
matks previously approved these changes Sep 28, 2021
View reviewed changes
PierreRambaud
PierreRambaud previously approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said it to you, it should be mention in the documentation, and be carefull, the new lock is file no longer backward compatible with old npm versions.

@NeOMakinG
Copy link
Author

As I said it to you, it should be mention in the documentation, and be carefull, the new lock is file no longer backward compatible with old npm versions.

We use lockfile v2, which is backward compatible with npm 6 and lockfiles 1

@NeOMakinG NeOMakinG dismissed stale reviews from PierreRambaud and matks via 8c6b3a2 September 29, 2021 12:54
PierreRambaud
PierreRambaud previously approved these changes Sep 29, 2021
View reviewed changes
@PierreRambaud
Copy link
Contributor

As I said it to you, it should be mention in the documentation, and be carefull, the new lock is file no longer backward compatible with old npm versions.

We use lockfile v2, which is backward compatible with npm 6 and lockfiles 1

Yeah, I misstook it with lockfile v3 -_-

atomiix
atomiix previously approved these changes Sep 30, 2021
View reviewed changes
@atomiix atomiix added the Waiting for QA Status: action required, waiting for test feedback label Sep 30, 2021
@boubkerbribri boubkerbribri self-assigned this Sep 30, 2021
@boubkerbribri
Copy link
Contributor

Waiting for #26118 to test all campaigns.

@NeOMakinG NeOMakinG dismissed stale reviews from atomiix and PierreRambaud via 7b88886 October 6, 2021 09:59
@PierreRambaud
Copy link
Contributor

Waiting for #26118 to test all campaigns.

The PR has been merged

@boubkerbribri
Copy link
Contributor

boubkerbribri commented Oct 6, 2021 •
edited

Waiting for #26118 to test all campaigns.

The PR has been merged

@PierreRambaud Tests started, could you review, please?

PierreRambaud
PierreRambaud previously approved these changes Oct 6, 2021
View reviewed changes
@NeOMakinG NeOMakinG removed the Waiting for QA Status: action required, waiting for test feedback label Oct 7, 2021
@atomiix atomiix closed this Oct 25, 2021
@atomiix atomiix reopened this Oct 25, 2021
atomiix
atomiix reviewed Oct 25, 2021
View reviewed changes
admin-dev/themes/new-theme/package-lock.json Outdated
"lockfileVersion": 2,
"lockfileVersion": 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be "lockfileVersion": 2?

Progi1984
Progi1984 previously approved these changes Oct 25, 2021
View reviewed changes
@Progi1984 Progi1984 self-requested a review October 25, 2021 13:54
@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Oct 25, 2021
@PierreRambaud PierreRambaud merged commit eca2fa9 into PrestaShop:develop Oct 27, 2021
@PierreRambaud
Copy link
Contributor

Thank you @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@atomiix atomiix atomiix approved these changes

@matks matks Awaiting requested review from matks

@Progi1984 Progi1984 Awaiting requested review from Progi1984

Assignees

@boubkerbribri boubkerbribri

Labels
develop Branch Improvement Type: Improvement Waiting for author Status: action required, waiting for author feedback
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@NeOMakinG @prestonBot @PierreRambaud @boubkerbribri @Progi1984 @atomiix @matks