Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for 1780 RC1 Build6 #26085

Merged

Conversation

sowbiba
Copy link
Contributor

@sowbiba sowbiba commented Oct 4, 2021

Questions Answers
Branch? 1.7.8.x
Description? Update changelog for 1.7.8.0 RC1 Build 6
Type? improvement
Category? CO

This change is Reviewable

@sowbiba sowbiba requested a review from a team as a code owner October 4, 2021 16:13
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added 1.7.8.x Branch Improvement Type: Improvement labels Oct 4, 2021
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is broken but this is because the Block Merge Commit GitHub Action is broken. When release is done we can force the merge.

@sowbiba sowbiba merged commit f6eb3c0 into PrestaShop:1.7.8.0-build Oct 5, 2021
@sowbiba sowbiba deleted the changelog-1780-rc1-build6 branch October 5, 2021 14:17
@matks matks added this to the 1.7.8.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.8.x Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants