Add a float parser for the wholesale price of attributes #26188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a float parser for the wholesale price of attributes
Progi1984
changed the title
Progi1984
approved these changes
Oct 11, 2021
matthieu-rolland
approved these changes
Oct 11, 2021
matks
approved these changes
Oct 11, 2021
PierreRambaud
approved these changes
Oct 13, 2021
PierreRambaud
added
the
Waiting for QA
|
Hello, |
marwachelly
added
QA ✔️
|
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
|
Contribution merged, congratulations! Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-) |
|
Thanks @andromaque & @marwachelly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to the Combinations tab, and then edit a combination
Enter a wholesale price for the combination (e.g. 1.55)
Save and go back to the product listing
Click to edit the same product
Click on Save and go back to the product listing
Click to edit the same product (for the 3rd time), go to the Combinations tab and click on the combination: the wholesale price is not rounded anymore.
This change is