Refactor controller tests #26437
Merged
Refactor controller tests #26437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and each action is now separated in a dedicated test function instead of being all done in the setup
…ral times which helps debugging, no need to clean the DB at each time
PierreRambaud
previously approved these changes
Oct 27, 2021
tegbessou
previously approved these changes
Oct 27, 2021
tests/Integration/PrestaShopBundle/Controller/GridControllerTestCase.php
Outdated
Show resolved
Hide resolved
jolelievre
dismissed stale reviews from tegbessou and PierreRambaud
via
e58b4f8
PierreRambaud
approved these changes
Oct 27, 2021
matks
approved these changes
Oct 27, 2021
| public function handleFor($id, FormInterface $form) | ||
| { | ||
| return $this->formHandler->handleFor($form, $id); | ||
| return $this->formHandler->handleFor($id, $form); |
There was a problem hiding this comment.
😮 woah this was probably introducing bugs before?
There was a problem hiding this comment.
Not yet, because it was not used The edition was never tested until now
Progi1984
approved these changes
Oct 27, 2021
|
Thank you @jolelievre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which makes the base class difficult to reuse
The generic behaviour remains the same but everything was split into separate methods that can be used when needed
Also separate into two abstract classes depending if you need to test the grid only or the form with it (not possible to test the form without the grid though)
This change is