Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal position on safari on order page #26465

Merged
merged 1 commit into from Nov 2, 2021
Merged

Fix modal position on safari on order page #26465

merged 1 commit into from Nov 2, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Oct 28, 2021 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? Form structure was wrong on the order page modals
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #22315.
How to test? Go on order view page on safari and open every modals
Possible impacts? Order page modals

This change is Reviewable

@NeOMakinG NeOMakinG added this to the 8.0.0 milestone Oct 28, 2021
@NeOMakinG NeOMakinG requested a review from a team as a code owner October 28, 2021 10:00
@NeOMakinG NeOMakinG changed the base branch from develop to 1.7.8.x October 28, 2021 10:00
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Oct 28, 2021
@NeOMakinG NeOMakinG modified the milestones: 8.0.0, 1.7.8.1 Oct 28, 2021
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Oct 28, 2021
@NeOMakinG NeOMakinG added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for wording Status: action required, waiting for wording labels Oct 29, 2021
@marwachelly marwachelly self-assigned this Oct 29, 2021
@marwachelly marwachelly added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 31, 2021
@marwachelly
Copy link

Hello,
The following modal are well displayed in the order page with iPad Air 4 v14.1 and iPhone 12 v14.1:

  • add new discount
  • shipping address > edit existing adress for
  • shipping address > select another adress
  • invoice address> edit existing adress
  • invoice address> select another adress
  • carriers> edit shipping detail
    image
    image
    image

@Progi1984 Progi1984 merged commit 8d63d3a into PrestaShop:1.7.8.x Nov 2, 2021
@Progi1984
Copy link
Contributor

Thanks @NeOMakinG & @marwachelly

@Progi1984 Progi1984 mentioned this pull request Nov 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@matks matks matks approved these changes

Assignees

@marwachelly marwachelly

Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.1
Development

Successfully merging this pull request may close these issues.

[UI-KIT] - BO - Order page - The Modal of adding a discount is not well displayed
6 participants
@NeOMakinG @marwachelly @Progi1984 @matthieu-rolland @matks @prestonBot