Fix display for invalid characters in tax name

[ghost]

Questions	Answers
Branch?	develop
Description?	See below
Type?	bug fix
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #26515
How to test?	Check if the invalid characters are good
Possible impacts?	No

Description

Currently the tax name validation uses generic_name
See this line.

The sprintf uses another rule see this line and these lines to see the all restrictions

---

This change is 

[tegbessou]

Thank you for your PR! IMO all is good

[HanaRebaiQA]

Hello,
The issue is not fixed.

See screen record :
https://www.awesomescreenshot.com/video/5993998?key=d3eb130321ac7c462d474321c5a6842a

Could you check it please !

Thanks,

[ghost]

Hello @HanaRebaiQA

We should be able to add # and ; in the name of the taxes.
My PR corrects the display of allowed characters.
I can edit to disallow # and ; but I don't understand why these characters are not allowed.

[HanaRebaiQA]

Hello @PrestaShop/product-team
I created the issue #26515 in order to fix the mismatch between the tax Name field and the message displayed bellow. But the PR fixes the message displayed bellow and not the tax Name field .
So with this PR the special characters ; and # will be allowed. What do you think?

Thanks in advance,

[ghost]

Hello @HanaRebaiQA can you change the label to Waiting for PM

Regards

[MatShir]

@PierreRambaud another one 🤔, IMO this field needs should accept every character.
LGTM but I have to put waiting for wording because the behavior is changing ;)
cc @Julievrz could you have a look specifically for the help text ;)

[Julievrz]

@PierreRambaud another one 🤔, IMO this field needs should accept every character. LGTM but I have to put waiting for wording because the behavior is changing ;) cc @Julievrz could you have a look specifically for the help text ;)

Yes, Hana had already told me about this issue. I don't see any reason why we shouldn't accept these characters. 👍

[ghost]

@Progi1984 or @PierreRambaud If you can add the label Waiting for QA

Sincerely

[HanaRebaiQA]

Hello @okom3pom

Thanks for your PR.
I have tested this PR and the issue is fixed. The actual behavior now is to allow all caracters expect these ones <>={} as mentioned in the displayed message. So, now the message and the restcition are both compatible. See screen-record below:
https://watch.screencastify.com/v/bcCUniaSgIquxqtHdKh9

So, QA ✔️

I verified the result also with mulilang, multistore

Thanks,

[prestonBot]

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

[matks]

Thank you @okom3pom