Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using _PS_PRICE_COMPUTE_PRECISION_ #26824

Merged
merged 5 commits into from Mar 21, 2022
Merged

Avoid using _PS_PRICE_COMPUTE_PRECISION_ #26824

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
897e33a
Substitute inequality operator for number string comparison with strc…
mpaolino Dec 6, 2021
8b21f74
Comply with PS coding style
mpaolino Dec 7, 2021
d1bfdf2
Improve validateOrder comment
mpaolino Dec 7, 2021
d7755bd
Update classes/PaymentModule.php
mpaolino Dec 9, 2021
ad342cd
Fixed PaymentModule comment regarding number string compare
mpaolino Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions classes/PaymentModule.php
View file
Open in desktop
Expand Up @@ -319,8 +319,10 @@ public function validateOrder(
// Amount paid by customer is not the right one -> Status = payment error
// We don't use the following condition to avoid the float precision issues : http://www.php.net/manual/en/language.types.float.php
// if ($order->total_paid != $order->total_paid_real)
// We use number_format in order to compare two string
if ($order_status->logable && number_format($cart_total_paid, Context::getContext()->getComputingPrecision()) != number_format($amount_paid, _PS_PRICE_COMPUTE_PRECISION_)) {
// We use number_format to convert the numbers to strings and strict inequality to compare them to avoid auto reconversions to numbers in PHP < 8.0
$comp_precision = Context::getContext()->getComputingPrecision();
if ($order_status->logable && (number_format($cart_total_paid, $comp_precision) !== number_format($amount_paid, $comp_precision))) {
PrestaShopLogger::addLog('PaymentModule::validateOrder - Total paid amount does not match cart total', 3, null, 'Cart', (int) $id_cart, true);
$id_order_state = Configuration::get('PS_OS_ERROR');
}

Expand Down