Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix post install error when fixture installation is disabled #26893

Merged
merged 1 commit into from Dec 10, 2021
Merged

Fix post install error when fixture installation is disabled #26893

merged 1 commit into from Dec 10, 2021

Conversation

unlocomqx
Copy link
Contributor

@unlocomqx unlocomqx commented Dec 6, 2021 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? When the demo data installation is disabled, the post install step raises an error
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #26892
How to test? See issue for steps
Possible impacts? Shouldn't impact any other areas of PrestaShop

This change is Reviewable

@unlocomqx unlocomqx requested a review from a team as a code owner December 6, 2021 15:18
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Dec 6, 2021
PierreRambaud
PierreRambaud previously approved these changes Dec 7, 2021
View reviewed changes
@unlocomqx unlocomqx changed the title Fix post install error when fixture installation is enabled Fix post install error when fixture installation is disabled Dec 8, 2021
@unlocomqx
Copy link
Contributor Author

I updated my code to be more semantically correct

@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Dec 9, 2021
@sarahdib sarahdib self-assigned this Dec 10, 2021
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 10, 2021
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@Progi1984 Progi1984 added this to the 8.0.0 milestone Dec 10, 2021
@Progi1984 Progi1984 merged commit 913ab43 into PrestaShop:develop Dec 10, 2021
@Progi1984
Copy link
Contributor

Thanks @unlocomqx & @sarahdib

@unlocomqx unlocomqx deleted the install-post-process branch December 10, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees

@sarahdib sarahdib

Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Post install fails when fixture installation is disabled
6 participants
@unlocomqx @prestonBot @Progi1984 @PierreRambaud @matthieu-rolland @sarahdib