Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 1.7.8.2-build in 1.7.8.x [merge] #26908

Merged
merged 7 commits into from Dec 7, 2021
Merged

Merge 1.7.8.2-build in 1.7.8.x [merge] #26908

merged 7 commits into from Dec 7, 2021

Conversation

matks
Copy link
Contributor

@matks matks commented Dec 7, 2021 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.8.x
Description? Merge 1.7.8.2-build in 1.7.8.x
Type? improvement
Category? ME
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? CI is green
Possible impacts?

This change is Reviewable

@matks matks requested a review from a team as a code owner December 7, 2021 13:38
@prestonBot prestonBot added 1.7.8.x Branch Improvement Type: Improvement labels Dec 7, 2021
Progi1984
Progi1984 reviewed Dec 7, 2021
View reviewed changes
app/AppKernel.php Outdated Show resolved Hide resolved
jolelievre
jolelievre reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit except the extra line in kernel

@matks @Progi1984
Remove useless empty line
5a551c9 
Co-authored-by: Progi1984 <franck.lefevre@prestashop.com>
@matks matks changed the title Merge 1.7.8.2-build in 1.7.8.x Merge 1.7.8.2-build in 1.7.8.x [merge] Dec 7, 2021
@PierreRambaud PierreRambaud merged commit 8e0cea1 into 1.7.8.x Dec 7, 2021
@PierreRambaud PierreRambaud deleted the merge1782buildin178x branch December 7, 2021 17:28
@PierreRambaud
Copy link
Contributor

Thank you @matks

@Progi1984 Progi1984 added this to the 1.7.8.3 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 left review comments

@jolelievre jolelievre jolelievre left review comments

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
1.7.8.x Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.8.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matks @PierreRambaud @Progi1984 @jolelievre @AfricanJoker @prestonBot