Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tools::addonsRequest('service') calls (Part 2) #27112

Merged
merged 1 commit into from Jan 4, 2022
Merged

Remove Tools::addonsRequest('service') calls (Part 2) #27112

merged 1 commit into from Jan 4, 2022

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Dec 28, 2021 •
edited

Questions Answers
Branch? develop
Description? Remove Tools::addonsRequest('service') calls (Part 2)
Type? refacto
Category? CO
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes #24741
How to test?

BC Breaks:

  • Removed method getServices in class PrestaShopBundle\Service\DataProvider\Marketplace\ApiClient

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner December 28, 2021 12:52
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring BC break Type: Introduces a backwards-incompatible break labels Dec 28, 2021
@Progi1984 Progi1984 added this to the 8.0.0 milestone Dec 28, 2021
PierreRambaud
PierreRambaud previously approved these changes Dec 28, 2021
View reviewed changes
@matthieu-rolland
Copy link
Contributor

rebase needed ;)

@Progi1984
Copy link
Contributor Author

@matthieu-rolland & @PierreRambaud Could you re-approve ? I have rebased.

@PierreRambaud PierreRambaud merged commit d6626ff into PrestaShop:develop Jan 4, 2022
@PierreRambaud
Copy link
Contributor

Thank you @Progi1984

@matks matks added the Needs documentation Needs an update of the developer documentation label Jul 19, 2022
@kpodemski kpodemski added Documentation ✔️ Developer documentation is up-to-date and removed Needs documentation Needs an update of the developer documentation labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@atomiix atomiix atomiix approved these changes

@matthieu-rolland matthieu-rolland Awaiting requested review from matthieu-rolland

Assignees
No one assigned
Labels
BC break Type: Introduces a backwards-incompatible break develop Branch Documentation ✔️ Developer documentation is up-to-date Refactoring Type: Refactoring
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Remove Tools::addonsRequest('service') calls
7 participants
@Progi1984 @matthieu-rolland @PierreRambaud @atomiix @kpodemski @matks @prestonBot