Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text nowrap to link btn inside grids #27429

Merged
merged 1 commit into from Jan 27, 2022
Merged

Add text nowrap to link btn inside grids #27429

merged 1 commit into from Jan 27, 2022

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Jan 21, 2022 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.8.x
Description? Buttons shouldn't wrap when the window size is reduced, prefer having an horizontal scroll
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #26779.
How to test? Generate a credit slip, go to credit slip grid and see if the button is fine when you're on mobile
Possible impacts? Grid link elements btn

This change is Reviewable

@NeOMakinG NeOMakinG added this to the 1.7.8.4 milestone Jan 21, 2022
@NeOMakinG NeOMakinG requested a review from a team as a code owner January 21, 2022 14:48
@prestonBot prestonBot added 1.7.8.x Branch Bug fix Type: Bug fix labels Jan 21, 2022
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jan 25, 2022
@HanaRebaiQA HanaRebaiQA self-assigned this Jan 26, 2022
HanaRebaiQA
HanaRebaiQA approved these changes Jan 26, 2022
View reviewed changes
Copy link

@HanaRebaiQA HanaRebaiQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NeOMakinG

Thanks for the fix.
I have checked this PR with responsive mode, on mobile, with multistire, with different languages and different browsers.

chrome and responsive mode :
image

mobile :
image

https://watch.screencastify.com/v/aXGlB5Hjldqc4nVbzOth

multistore + RTL language :
image

firefox :
image

So, QA ✔️

Thanks!

@HanaRebaiQA HanaRebaiQA added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 26, 2022
@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Jan 26, 2022
@NeOMakinG NeOMakinG removed the Waiting for author Status: action required, waiting for author feedback label Jan 27, 2022
@Progi1984 Progi1984 merged commit 83965f9 into PrestaShop:1.7.8.x Jan 27, 2022
@Progi1984
Copy link
Contributor

Thanks @NeOMakinG & @HanaRebaiQA

@Progi1984 Progi1984 linked an issue Jan 27, 2022 that may be closed by this pull request
[BO - Mobile] Button "Download credit slip" is not well displayed #26779
Closed
2 tasks
@Progi1984 Progi1984 mentioned this pull request Jan 27, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matks matks matks approved these changes

@HanaRebaiQA HanaRebaiQA HanaRebaiQA approved these changes

Assignees

@HanaRebaiQA HanaRebaiQA

Labels
1.7.8.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.4
Development

Successfully merging this pull request may close these issues.

[BO - Mobile] Button "Download credit slip" is not well displayed
6 participants
@NeOMakinG @Progi1984 @PierreRambaud @matks @HanaRebaiQA @prestonBot