Remove deprecated variable _PS_PRICE_COMPUTE_PRECISION_

[idnovate]

Deprecated _PS_PRICE_COMPUTE_PRECISION_ instead of Context::getContext()->getComputingPrecision() was used. This cause an error when value from the 2 variables didn't match.

Questions	Answers
Branch?	develop
Description?	When the value from _PS_PRICE_COMPUTE_PRECISION_ and Context::getContext()->getComputingPrecision() was different, the order was created as Payment Error
Type?	bug fix
Category?	FO
BC breaks?	no
Deprecations?	no

---

This change is 

[prestonBot]

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

• Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

• If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
• It can help trigger a discussion about the best implementation path before a single line of code is written.
• It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

[PierreRambaud]

Hi and thanks for your contribution.
Could you please remove the define in config.inc.php as the constant has been tagged as deprecated in 1.7.7.
If you feel comfortable, you can also do it for _PS_PRICE_DISPLAY_PRECISION_ which was also deprecated in the same version

[matthieu-rolland]

thanks @idnovate , this is indeed deprecated and should be removed

@idnovate do you think we should have a reproducible step by step use case for the QA team, so that they can test it?

Since the PR is described as a bug fix...

[idnovate]

thanks @idnovate , this is indeed deprecated and should be removed

@idnovate do you think we should have a reproducible step by step use case for the QA team, so that they can test it?

Since the PR is described as a bug fix...

Ok

[idnovate]

Hi and thanks for your contribution. Could you please remove the define in config.inc.php as the constant has been tagged as deprecated in 1.7.7. If you feel comfortable, you can also do it for _PS_PRICE_DISPLAY_PRECISION_ which was also deprecated in the same version

But this could be a BC break if modules or custom developments use this variable.

[idnovate]

thanks @idnovate , this is indeed deprecated and should be removed

@idnovate do you think we should have a reproducible step by step use case for the QA team, so that they can test it?

Since the PR is described as a bug fix...

How to reproduce it and test it?

1. Set 0 decimals for a currency:

2. Set Order status as logable:

3. Place an order with a product above 999€:

4. Order is created with Payment error:

@idnovate Could you create a dedicated issue for validating it by the @PrestaShop/qa-functional team ?

#27902

[Progi1984]

@idnovate Could you create a dedicated issue for validating it by the @PrestaShop/qa-functional team ?

[kpodemski]

In the createOrderCartRules you have this variable already available.

In the first method, you could create if it's in a few places.

[kpodemski]

Thanks @idnovate

I added a little feedback.

Also, this is a duplication of:
#27436

But I see that you changed the variable in the remaining places, good 👍

[matks]

Friendly reminder @idnovate 😉 also this PR requires a git rebase

[Progi1984]

@idnovate Could you rebase your PR and remove your merge commits, please ?

[idnovate]

@idnovate Could you rebase your PR and remove your merge commits, please ?

Is it OK now? 😕

[Progi1984]

@idnovate No you have always merge commits. Check here : https://github.com/PrestaShop/PrestaShop/pull/27630/commits.

[idnovate]

#28388