Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Adapter\Tools::link_rewrite #27960

Merged
merged 1 commit into from Apr 6, 2022
Merged

Remove Adapter\Tools::link_rewrite #27960

merged 1 commit into from Apr 6, 2022

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Mar 18, 2022 •
edited

Questions Answers
Branch? develop
Description? Remove Adapter\Tools::link_rewrite
Type? improvement
Category? CO
BC breaks? yes - Remove Adapter\Tools::link_rewrite
Deprecations? no
Fixed ticket? Fixes #26293
How to test? Tests are green.
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner March 18, 2022 10:08
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Mar 18, 2022
saulaski
saulaski reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@saulaski saulaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible impact ?

PrestaShop/src/PrestaShopBundle/Model/Product/AdminModelAdapter.php

Line 376 in 10e33c0

$form_data[$linkRewriteKey] = $this->tools->link_rewrite($form_data['name_' . $this->locales[0]['id_lang']]);

@matthieu-rolland matthieu-rolland added this to the 8.0.0 milestone Mar 22, 2022
@PierreRambaud
Copy link
Contributor Author

Nope as I already changed it :)

Progi1984
Progi1984 requested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thank you for your contribution. Could you add a linked PR on the devdocs : https://devdocs.prestashop.com/8/modules/core-updates/8.0/#removals ?

@matks matks added Needs documentation Needs an update of the developer documentation BC break Type: Introduces a backwards-incompatible break labels Apr 6, 2022
@matks
Copy link
Contributor

matks commented Apr 6, 2022

Thank you @PierreRambaud

@matks matks merged commit 7536883 into PrestaShop:develop Apr 6, 2022
@matks matks self-assigned this Apr 6, 2022
@kpodemski kpodemski added Documentation ✔️ Developer documentation is up-to-date and removed Needs documentation Needs an update of the developer documentation labels Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulaski saulaski saulaski left review comments

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

Assignees

@matks matks

Labels
BC break Type: Introduces a backwards-incompatible break develop Branch Documentation ✔️ Developer documentation is up-to-date Improvement Type: Improvement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Remove deprecated related to older PrestaShop version
7 participants
@PierreRambaud @matks @Progi1984 @saulaski @matthieu-rolland @kpodemski @prestonBot