Combination bulk actions progress modal

[zuk3975]

Questions	Answers
Branch?	8.0.x
Description?	Add progress modal (which was introduced in #26004) to Combination bulk actions in new product page. Also make bulk endpoint accept array of combinationIds and handle form violation errors visualisation.
Type?	refacto
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?
Related PRs	If theme, autoupgrade or other module change is needed, provide a link to related PRs here.
How to test?	Try bulk actions in new product combination page. It should show progress modal same as in product page.
Possible impacts?

[prestonBot]

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

• Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

• If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
• It can help trigger a discussion about the best implementation path before a single line of code is written.
• It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

[prestonBot]

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

• Admin.Notifications.Error
  • Form contains invalid values
• Admin.Notification.Error
  • Error for combination %combination_id%: %error_message%
• Admin.Catalog.Feature
  • Deleting %total% combinations
  • Deleting %done%/%total% combinations
  • Close
  • Stop processing
  • %error_count% errors occurred. You can download the logs for future reference.
  • Back to processing
  • Download error log
  • View %error_count% error logs
  • Error log
  • Editing %total% combinations
  • Editing %done%/%total% combinations

(Note: this is an automated message, but answering it will reach a real human)

[zuk3975]

Some concerns:

1. There was one very strange behavior, but it disappeared and I couldn't reproduced it anymore - sometimes when form violations occurred, the js components failed to initialize (resulting in no dynamics in the form at all - disabling switches wouldn't work as well as DeltaQuantityInput)
2. After form violation errors if you edited one field and it failed, once you switch that field off, the submit button is enabled even though it doesn't make much sense from user perspective (because then you can submit empty form, because all inputs are disabled). Couldn't find an easy way to fix it, so its still there.

[NeOMakinG]

Some small comments, but overall lgtm

[jolelievre]

Thanks @zuk3975

great work this one turned out to be more complex than I anticipated. I have a few minor suggestions that are not that important. But the main comment is about how we could handle the form validation a bit more cleanly see the big comment on bulk-edition-handler.ts in particular

And I also suggested a possible optimization of the bulk controller

[jolelievre]

Suggested change

	* This property contains a form content fetched from api when form constraints are violated during form submit.
	* This form will already have rendered errors where they belong (depending on violated fields).
	* This property contains a form content fetched from api when form constraints are invalid during form submit.
	* This form will already have rendered errors where they belong (depending on invalid fields).

[jolelievre]

I think this part could be optimized, for now the form is rebuilt for each provided combination but it's always the same data so no need to build the form in the loop it could be built only once outside of the loop

[jolelievre]

Thanks @zuk3975