Fix carrier Exeption with free shipping #28788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
matthieu-rolland
approved these changes
Jun 20, 2022
2 tasks
Progi1984
approved these changes
Jun 20, 2022
Progi1984
added
the
Waiting for QA
sLorenzini
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
hello @okom3pom,
Tested with 8.0.x branch with PHP 7.2 version.
Tested on:
BO > add free shipping > edit > ✅ , FO > carrier has free shipping > ✅
BO > add status > edit > ✅ , FO > carrier is enabled > ✅
BO > remove free shipping > edit > ✅ , FO > carrier has no free shipping > ✅
BO > remove status > edit > ✅ , FO > carrier is disabled > ✅
Tested with carrier already existing in the shop and new carrier
QA approved ✅
Thanks
sLorenzini
added
QA ✔️
|
Thanks @okom3pom & @sLorenzini |
2 tasks
ghost
mentioned this pull request
2 tasks
ghost
mentioned this pull request
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ I have deleted the deprecated