Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*] BO : Pass the object we're displaying to the action{$controller}Form... #2880

Closed
wants to merge 1 commit into from
Closed

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Apr 15, 2015

...Modifier hook

This allows modules to register a hook instead of overriding the whole controller to add a new section to "display" templates

…ormModifier hook

This allows modules to register a hook instead of overriding the whole controller to add a new section to "display" templates
@vTerenti
Copy link
Contributor

vTerenti commented Nov 5, 2015

(note: this is an automated message, but answering it will reach a real human )

Hi! Thank you for your pull request: your contribution to PrestaShop means a lot to us!

We are aware that this PR is still open after all this time, and we want to make sure that your hard work is not forgotten.

We are diving back into pull requests, and we want to work with you in order to get your PR to completion: we need your feedback!

Could you read this article from the Build devblog, and take the time to review your pull requests, so that we can work with up-to-date information? You don't have to do it all right now, and every little step helps.

Again, thank you very much for this contribution, and for your renewed feedback on it!

@tiennou
Copy link
Contributor Author

tiennou commented Nov 5, 2015

This one still holds. Maybe there's a better Core-sanctioned way of doing it, but this seemed the cleanest way to go...

@xBorderie
Copy link
Contributor

Thank you for your feedback @tiennou !

Since this PR was made on the '1.6' branch, could you make it again on the '1.6.1.x' branch so that you get full credit once we merge it? Even better if you do it on the 'develop' branch, so that it lands in PS 1.7 :)

Thank you very much!

@tiennou
Copy link
Contributor Author

tiennou commented Nov 5, 2015

Here comes a PR against develop then ;-).

@xBorderie
Copy link
Contributor

Great, thank you very much Étienne!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants