Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default meta description #28942

Merged
merged 2 commits into from Sep 26, 2022
Merged

Remove default meta description #28942

merged 2 commits into from Sep 26, 2022

Conversation

jf-viguier
Copy link
Contributor

Questions Answers
Branch? develop
Description? Remove default meta description "Shop powered by PrestaShop", and improve prestashop beginner seo
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #28941
How to test? Install prestashop, see that the meta description is not here anymore
Possible impacts? none

@jf-viguier jf-viguier requested a review from a team as a code owner July 4, 2022 08:52
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jul 4, 2022
@micka-fdz
Copy link
Contributor

Hi @jf-viguier, nice PR!

I think you can also remove this wording here:

PrestaShop/classes/lang/KeysReference/MetaLang.php

Line 57 in 6f8365e

trans('Shop powered by PrestaShop', 'Shop.Navigation');

NeOMakinG
NeOMakinG previously approved these changes Jul 4, 2022
View reviewed changes
Copy link

@NeOMakinG NeOMakinG left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

micka-fdz
micka-fdz previously approved these changes Jul 5, 2022
View reviewed changes
matks
matks previously approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR valid for code, I can't tell if this is expected behavior though :D

kpodemski
kpodemski previously approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it is probably better to have no description than a description saying that it's a store powered by PrestaShop. One of the common mistakes merchant's do is not changing this later :)

@NeOMakinG NeOMakinG added the Waiting for QA Status: action required, waiting for test feedback label Jul 12, 2022
@florine2623 florine2623 self-assigned this Jul 13, 2022
florine2623
florine2623 reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jf-viguier ,

In Traffic & SEO, the description as been removed:
Screenshot 2022-07-15 at 12 28 11

But in Translation, I still see "Shop powered by PrestaShop", as you can see here:
Screenshot 2022-07-15 at 12 28 20

What do you think ?

@florine2623 florine2623 added the Waiting for author Status: action required, waiting for author feedback label Jul 15, 2022
@florine2623 florine2623 removed the Waiting for QA Status: action required, waiting for test feedback label Jul 27, 2022
@kpodemski
Copy link
Contributor

@florine2623

I don't think it's related. We need to export .xlf files for a new release, and then it should be all good.

@kpodemski
Copy link
Contributor

@jf-viguier could you rebase your PR? :)

@kpodemski kpodemski added the Waiting for rebase Status: action required, waiting for rebase label Jul 29, 2022
@ghost ghost mentioned this pull request Aug 1, 2022
Merged
@prestonBot
Copy link
Collaborator

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Sep 1, 2022
@jf-viguier
Copy link
Contributor Author

@kpodemski rebase done

kpodemski
kpodemski previously approved these changes Sep 12, 2022
View reviewed changes
@kpodemski kpodemski removed Waiting for author Status: action required, waiting for author feedback Waiting for rebase Status: action required, waiting for rebase Waiting for wording Status: action required, waiting for wording labels Sep 12, 2022
FabienPapet
FabienPapet previously approved these changes Sep 13, 2022
View reviewed changes
micka-fdz
micka-fdz previously approved these changes Sep 13, 2022
View reviewed changes
matks
matks previously requested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry :( there is one more rebase to do as file classes/lang/KeysReference/MetaLang.php is in conflict

@jf-viguier
Copy link
Contributor Author

@matks rebase done

kpodemski
kpodemski previously approved these changes Sep 14, 2022
View reviewed changes
@atomiix atomiix closed this Sep 21, 2022
@atomiix atomiix reopened this Sep 21, 2022
@atomiix
Copy link
Contributor

atomiix commented Sep 21, 2022

Closed/reopened to trigger the CI

@atomiix
Copy link
Contributor

atomiix commented Sep 21, 2022

I think @micka-fdz's comment is not here anymore?

Hi @jf-viguier, nice PR!

I think you can also remove this wording here:

PrestaShop/classes/lang/KeysReference/MetaLang.php

Line 57 in 6f8365e

trans('Shop powered by PrestaShop', 'Shop.Navigation');

@jf-viguier
Copy link
Contributor Author

@atomiix it's done

@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Sep 23, 2022
florine2623
florine2623 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jf-viguier ,

No message 'Shop powered by PrestaShop' written in Traffic & SEO. Possible to add a custom meta description.

It is QA ✅
Thanks!

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Sep 26, 2022
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@atomiix atomiix added this to the 8.1.0 milestone Sep 26, 2022
@atomiix atomiix merged commit 8846de3 into PrestaShop:develop Sep 26, 2022
@atomiix
Copy link
Contributor

atomiix commented Sep 26, 2022

Thanks @jf-viguier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@matks matks matks approved these changes

@florine2623 florine2623 florine2623 approved these changes

@FabienPapet FabienPapet FabienPapet left review comments

@kpodemski kpodemski kpodemski left review comments

@NeOMakinG NeOMakinG NeOMakinG left review comments

@micka-fdz micka-fdz micka-fdz left review comments

Assignees

@florine2623 florine2623

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

Remove default meta description "Shop powered by PrestaShop"
10 participants
@jf-viguier @micka-fdz @kpodemski @prestonBot @atomiix @FabienPapet @matthieu-rolland @matks @NeOMakinG @florine2623