Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] CORE: Fix isEmail() regexp, follow up 62798af #2911

Conversation

websafe
Copy link

@websafe websafe commented Apr 21, 2015

Fix "This e-mail address is invalid" on systems with older PCRE versions.
For details please check my comment on commit 62798af

@gRoussac
Copy link
Contributor

Hi,

Thank you for your PR.

Can you just please edit title to [-] CORE: Fix isEmail() regexp, follow up 62798af ?

http://doc.prestashop.com/display/PS15/How+to+write+a+commit+message

Thank you Regards

@gRoussac gRoussac changed the title Fix "This e-mail address is invalid" on systems with older PCRE versions [-] CORE: Fix isEmail() regexp, follow up 62798af Apr 21, 2015
@websafe websafe changed the title [-] CORE: Fix isEmail() regexp, follow up 62798af [-] CORE: Fix isEmail() regexp, follow up 62798af Apr 21, 2015
@websafe websafe changed the title [-] CORE: Fix isEmail() regexp, follow up 62798af [-] CORE: Fix isEmail() regexp, follow up #62798af Apr 21, 2015
@websafe websafe changed the title [-] CORE: Fix isEmail() regexp, follow up #62798af [-] CORE: Fix isEmail() regexp, follow up 62798af Apr 21, 2015
@vTerenti
Copy link
Contributor

vTerenti commented Nov 5, 2015

(note: this is an automated message, but answering it will reach a real human )

Hi! Thank you for your pull request: your contribution to PrestaShop means a lot to us!

We are aware that this PR is still open after all this time, and we want to make sure that your hard work is not forgotten.

We are diving back into pull requests, and we want to work with you in order to get your PR to completion: we need your feedback!

Could you read this article from the Build devblog, and take the time to review your pull requests, so that we can work with up-to-date information? You don't have to do it all right now, and every little step helps.

Again, thank you very much for this contribution, and for your renewed feedback on it!

@xBorderie xBorderie added Waiting for QA Status: action required, waiting for test feedback Estimate: M labels May 24, 2016
@vTerenti
Copy link
Contributor

Hello!

This PR has been automatically closed because the branch 1.6 does not exist anymore.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug Waiting for QA Status: action required, waiting for test feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants