Remove empty category blocks in module manager

[eternoendless]

Questions	Answers
Branch?	develop
Description?	Whenever there is no module in a category, the block is no longer shown.
Type?	improvement
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #30260
Related PRs	#30810 (To merge together)
How to test?	Load module manager. See the empty blocks are no longer there
Possible impacts?	None?

Before:

After:

[kpodemski]

src/PrestaShopBundle/Resources/views/Admin/Module/Includes/grid_manage_empty.html.twig
This file has been modified recently with this hook:

{{ renderhook('displayEmptyModuleCategoryExtraMessage', {'category_name': category.name}) }}

To meet requirements from the SMB edition. @MatShir approved it

I think it looks better without this information, but it would be good to align on this topic.

[ghost]

@kpodemski I don't know? there was ps_mbo for ads before? not here?

[kpodemski]

@okom3pom I don't know. I just want to avoid going back and forth with changes that were previously (not that long ago) approved :D

[MatShir]

The issue was approved, I make sense to add content for marketplace module in the module manager #28317. UX could be enhanced ofc. It looks a good option to hide the block when nobody is hooked to it, only if we don't remove the hooks. Could you confirm @eternoendless?

[matks]

Waiting for @eternoendless feedback: this PR currently disables the use of the hook mentioned by @kpodemski . So it seems we don't want to merge it like this.

[Hlavtox]

@eternoendless @matks

{% block catalog_category_empty %}
  {% set hookData = renderhook('displayEmptyModuleCategoryExtraMessage', {'category_name': category.name}) %}
  {% if hookData is not empty %}
    <div class="modules-list module-list-empty" data-name="{{ category.refMenu }}">
      <p>{{ 'You do not have module in « %categoryName% ».' | trans({'%categoryName%': category.name}, 'Admin.Modules.Feature') }}</p>
      {{ hookData }}
    </div>
  {% endif %}
{% endblock %}

[eternoendless]

Fixed using @Hlavtox's suggestion 👍

I had to move the category name inside the block though. I also removed the wording, which not only had spelling and punctuation errors, but I also found it useless if you're adding content...

[NeOMakinG]

🍬

[sLorenzini]

hello @eternoendless,

Thank you for the PR.
To make a review in QA, we need to have an issue linked to the PR 😃 please 🙏

Thanks in advance

[kpodemski]

@sLorenzini

I've just created an issue to unblock this PR:
#30260

Could you add proper labels to it? because it has already been accepted,

[MhiriFaten]

Hello @eternoendless ,

I checked this PR and I the issue is well fixed ✔️
But the automated tests are failed in BO:modules test.

https://github.com/MhiriFaten/testing_pr/actions/runs/3443969574/jobs/5748649304

ping @PrestaShop/qa-automation Could you please check it ?

Thank you !

[boubkerbribri]

It's seems that the test should be updated, we will take a look.

[nesrineabdmouleh]

Hello @eternoendless @MhiriFaten @boubkerbribri

Thank you for the PR and the tests !
I create this PR to fix the failed automated tests 💯

The 2 PRs should be merged together :)
QA ✔️

Thank you!

[prestonBot]

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

[matks]

@FabienPapet don't forget to add the milestone ;)

[boubkerbribri]

And please don't forget if there is a PR that's related (here was to fix UI tests)