Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved structure for error message generation in configuration pages #29494

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

Improved structure for error message generation in configuration pages #29494

wants to merge 29 commits into from
+1,087 −137

Commits on May 31, 2023

  1. Adding tests

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    393b7c8 View commit details
    Browse the repository at this point in the history

  2. Fixed test

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4507b03 View commit details
    Browse the repository at this point in the history

  3. Added missing comment for function

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5d7a486 View commit details
    Browse the repository at this point in the history

  4. CS fixer fix

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    eaea148 View commit details
    Browse the repository at this point in the history

  5. Fixing label provider test

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    b659ae4 View commit details
    Browse the repository at this point in the history

  6. Fixing configuration error factory test

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4dbeec1 View commit details
    Browse the repository at this point in the history

  7. Removed accidentally added exception

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    ea18922 View commit details
    Browse the repository at this point in the history

  8. Removed accidentally added exception

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0e07dc8 View commit details
    Browse the repository at this point in the history

  9. Adding back const to avoid BC break, change test to use interface

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f509c54 View commit details
    Browse the repository at this point in the history

  10. Adding back old collection and error and depricating them

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f83d050 View commit details
    Browse the repository at this point in the history

  11. Added deprication trigger error

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    2257542 View commit details
    Browse the repository at this point in the history

  12. Removed not needed language repository from AdministrationConfigurati… 

    …onErrorMessageProvider.php fixed tests
    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    bd51aef View commit details
    Browse the repository at this point in the history

  13. Fixing unit tests

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    059386b View commit details
    Browse the repository at this point in the history

  14. Removed unneeded comment

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    fd1ec28 View commit details
    Browse the repository at this point in the history

  15. Removed unneeded public, changing classes naming to FQCN

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    2303177 View commit details
    Browse the repository at this point in the history

  16. Removing uneeded class

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    13be1cd View commit details
    Browse the repository at this point in the history

  17. Replacing with symfony contracts

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e03ab92 View commit details
    Browse the repository at this point in the history

  18. CS fixer fix

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    53cc57a View commit details
    Browse the repository at this point in the history

  19. Adding autowiring to new services

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e79d002 View commit details
    Browse the repository at this point in the history

  20. Using the class in AdministrationController.php

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    8bbd639 View commit details
    Browse the repository at this point in the history

  21. Update src/PrestaShopBundle/Form/ErrorMessage/Factory/AdministrationC… 

    …onfigurationErrorMessageProvider.php


Wording changes

Co-authored-by: l-delin <113511191+l-delin@users.noreply.github.com>
    @JevgenijVisockij @l-delin
    JevgenijVisockij and l-delin committed May 31, 2023
    Configuration menu
    Copy the full SHA
    00ef072 View commit details
    Browse the repository at this point in the history

  22. Made ConfigurationErrorFactory public because it was causing fatal

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    ce7d80f View commit details
    Browse the repository at this point in the history

  23. Refactored yml file to use autowire properly

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    ae400cc View commit details
    Browse the repository at this point in the history

  24. Adding back label provider and ConfigurationErrorCollection.php

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    667c29d View commit details
    Browse the repository at this point in the history

  25. Cs Fixer fix

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    311f56d View commit details
    Browse the repository at this point in the history

  26. Fixing to use MAX_COOKIE_VALUE from cookie options

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f9a84a1 View commit details
    Browse the repository at this point in the history

  27. Cs Fixer fix

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c046cbc View commit details
    Browse the repository at this point in the history

  28. syntax fix

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f32ea6d View commit details
    Browse the repository at this point in the history

  29. Fixed bug with wrong error

    @JevgenijVisockij
    JevgenijVisockij committed May 31, 2023
    Configuration menu
    Copy the full SHA
    ed8990a View commit details
    Browse the repository at this point in the history