Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reset customization in FO when changing combination (178x) #29635

Merged
merged 6 commits into from Sep 16, 2022
Merged

Do not reset customization in FO when changing combination (178x) #29635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3efbb14
do not reset customization in FO when changing combination
zuk3975 Aug 2, 2022
ce6aa66
refill customizationId value when updating quantity, but reset it el…
zuk3975 Aug 3, 2022
9c29064
do not reset id_customization when changing combination too
zuk3975 Aug 3, 2022
45cc9f6
fix loading cart for viewing when it contains product with recently …
zuk3975 Sep 14, 2022
756abde
surround OR statement with parenthesis
zuk3975 Sep 14, 2022
07811f1
fix js linter
zuk3975 Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions controllers/front/ProductController.php
View file
Open in desktop
Expand Up @@ -481,6 +481,7 @@ public function displayAjaxRefresh()
'product_minimal_quantity' => $minimalProductQuantity,
'product_has_combinations' => !empty($this->combinations),
'id_product_attribute' => $product['id_product_attribute'],
'id_customization' => $product['id_customization'],
'product_title' => $this->getProductPageTitle(
$this->getTemplateVarPage()['meta'] ?? []
),
Expand Down
3 changes: 2 additions & 1 deletion src/Adapter/Cart/QueryHandler/GetCartForViewingHandler.php
View file
Open in desktop
Expand Up @@ -221,7 +221,8 @@ private function prepareProductForView(array $products, Currency $currency, int
'unit_price' => $product['product_price'],
'total_price_formatted' => $this->locale->formatPrice($product['product_total'], $currency->iso_code),
'unit_price_formatted' => $this->locale->formatPrice($product['product_price'], $currency->iso_code),
'image' => $this->imageManager->getThumbnailForListing($image['id_image']),
// it is possible that there is no image for product, so we don't show anything, but at least avoid breaking whole page
'image' => isset($image['id_image']) ? $this->imageManager->getThumbnailForListing($image['id_image']) : '',
];

if (isset($product['customizationQuantityTotal'])) {
Expand Down
12 changes: 11 additions & 1 deletion themes/_core/js/product.js
View file
Open in desktop
Expand Up @@ -228,7 +228,17 @@ function updateProduct(event, eventType, updateUrl) {
$(prestashop.selectors.product.customization)
.first()
.replaceWith(data.product_customization);
$(prestashop.selectors.product.inputCustomization).val(0);

// refill customizationId input value when updating quantity or combination
if (
(eventType === 'updatedProductQuantity' || eventType === 'updatedProductCombination')
&& data.id_customization
) {
$(prestashop.selectors.cart.productCustomizationId).val(data.id_customization);
} else {
$(prestashop.selectors.product.inputCustomization).val(0);
}

$(prestashop.selectors.product.variantsUpdate)
.first()
.replaceWith(data.product_variants);
Expand Down