Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Tests : check:step-identifiers : Improved error message & Added check for baseContext #30299

Merged
merged 3 commits into from Nov 30, 2022
Merged

Functional Tests : check:step-identifiers : Improved error message & Added check for baseContext #30299

merged 3 commits into from Nov 30, 2022

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Nov 15, 2022 •
edited

Questions Answers
Branch? develop
Description? check:step-identifiers : Improved error message & Added check for baseContext
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Related PRs N/A
How to test? N/A
Possible impacts? N/A

@Progi1984 Progi1984 added TE Category: Tests E2E Tests labels Nov 15, 2022
@Progi1984 Progi1984 added this to the 8.1.0 milestone Nov 15, 2022
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Nov 15, 2022
@Progi1984 Progi1984 force-pushed the checkBaseContext branch 2 times, most recently from 788eb02 to ee44f8e Compare November 16, 2022 09:59
@Progi1984 Progi1984 changed the title Functional Tests : check:step-identifiers : Improved error message Functional Tests : check:step-identifiers : Improved error message & Added check for baseContext Nov 16, 2022
@Progi1984 Progi1984 marked this pull request as ready for review November 16, 2022 10:00
@Progi1984 Progi1984 requested review from a team as code owners November 16, 2022 10:00
matks
matks requested changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a git conflict :(

@Progi1984 Progi1984 requested a review from a team as a code owner November 28, 2022 08:03
@Progi1984 Progi1984 requested a review from matks November 28, 2022 08:04
@Progi1984
Copy link
Contributor Author

Thanks @matks. I rebased it :)

@Progi1984 Progi1984 added the QA ✔️ Status: check done, code approved label Nov 30, 2022
@matks
Copy link
Contributor

matks commented Nov 30, 2022

Thank you @Progi1984

@matks matks merged commit 4c9fa1a into PrestaShop:develop Nov 30, 2022
@Progi1984 Progi1984 deleted the checkBaseContext branch November 30, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@SD1982 SD1982 SD1982 approved these changes

@boubkerbribri boubkerbribri Awaiting requested review from boubkerbribri

@cfarhani06 cfarhani06 Awaiting requested review from cfarhani06

@nesrineabdmouleh nesrineabdmouleh Awaiting requested review from nesrineabdmouleh

Assignees
No one assigned
Labels
develop Branch E2E Tests Improvement Type: Improvement QA ✔️ Status: check done, code approved TE Category: Tests
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Progi1984 @matks @nesrineabdmouleh @SD1982 @prestonBot