New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Symfony/Component/Translation by Symfony/Contracts/Translation in every file #30496
Replace Symfony/Component/Translation by Symfony/Contracts/Translation in every file #30496
Conversation
FabienPapet
commented
Dec 5, 2022
•
edited
edited
Questions | Answers |
---|---|
Branch? | develop |
Description? | This interface is deprecated and will be removed in |
Type? | improvement |
Category? | CO |
BC breaks? | yes (DI) |
Deprecations? | no |
Fixed ticket? | |
Related PRs | |
How to test? | CI & automated tests |
Possible impacts? | n/A |
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
49e9173
to
3b6a1f9
Compare
Hello @FabienPapet There are failures in CI here, Could you please check it? Thank You! |
840fc12
3b6a1f9
to
840fc12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
Thanks @FabienPapet 🚀 |