Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Symfony/Component/Translation by Symfony/Contracts/Translation in every file #30496

Merged

Conversation

FabienPapet
Copy link
Member

@FabienPapet FabienPapet commented Dec 5, 2022

Questions Answers
Branch? develop
Description? This interface is deprecated and will be removed in
Type? improvement
Category? CO
BC breaks? yes (DI)
Deprecations? no
Fixed ticket?
Related PRs
How to test? CI & automated tests
Possible impacts? n/A

@FabienPapet FabienPapet requested a review from a team as a code owner December 5, 2022 09:19
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Dec 5, 2022
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added BC break Type: Introduces a backwards-incompatible break Bug fix Type: Bug fix labels Dec 5, 2022
@FabienPapet FabienPapet force-pushed the fix-deprecation-translation branch 3 times, most recently from 49e9173 to 3b6a1f9 Compare December 5, 2022 09:29
zuk3975
zuk3975 previously approved these changes Dec 5, 2022
nicosomb
nicosomb previously approved these changes Dec 6, 2022
@nicosomb nicosomb added the Waiting for QA Status: action required, waiting for test feedback label Dec 6, 2022
@HanaRebaiQA
Copy link

HanaRebaiQA commented Dec 6, 2022

Hello @FabienPapet

There are failures in CI here,
image

Could you please check it?

Thank You!

@HanaRebaiQA HanaRebaiQA added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 6, 2022
@nicosomb nicosomb added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels Dec 6, 2022
@MhiriFaten MhiriFaten self-assigned this Dec 6, 2022
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @FabienPapet ,

I launched the automated tests and it's OK ✔️

Thank you !

@MhiriFaten MhiriFaten added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 6, 2022
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@zuk3975
Copy link
Contributor

zuk3975 commented Dec 6, 2022

Thanks @FabienPapet 🚀

@zuk3975 zuk3975 merged commit 9adec9a into PrestaShop:develop Dec 6, 2022
@zuk3975 zuk3975 added this to the 8.1.0 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Type: Introduces a backwards-incompatible break Bug fix Type: Bug fix develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants