Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use customization in displayed prices calculation #30848

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tom-combet
Copy link
Contributor

@tom-combet tom-combet commented Jan 12, 2023

Questions Answers
Branch? develop
Description? Use customization when calculating the prices to display. Useless for the core but useful for module developers when adding prices for customization fields.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? #30849
Related PRs N/A
How to test? Customize a customizable product in FO and change its price in customized_data table. Refresh the page and customization price should be added to product initial price.
Possible impacts? None

@tom-combet tom-combet requested a review from a team as a code owner January 12, 2023 20:31
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jan 12, 2023
@tom-combet tom-combet changed the title Use customization in price calculation Use customization in displayed prices calculation Jan 12, 2023
@kpodemski
Copy link
Contributor

Hi @tom-combet

We'll need detailed How to test, and the best would be to have a dedicated Issue because this is a critical part of the software.

@tom-combet
Copy link
Contributor Author

Hi @tom-combet

We'll need detailed How to test, and the best would be to have a dedicated Issue because this is a critical part of the software.

Hi @kpodemski,

I'll make an issue but it will difficult to be clearer for How to test section...

@kpodemski
Copy link
Contributor

@tom-combet yes, how to test seems easy to understand, thanks! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants