Add shop constraint on SetAssociatedProductCategoriesCommand and RemoveAllAssociatedProductCategoriesCommand #31047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonBot
added
develop
jolelievre
force-pushed
the
product-categories-multishop
branch
from
4932fd2
to
b91f04f
Compare
…e the default category from the creation shop
jolelievre
force-pushed
the
product-categories-multishop
branch
from
a835275
to
9b523e2
Compare
jolelievre
changed the title
zuk3975
reviewed
Jan 27, 2023
| And I edit category "women" with following details: | ||
| | associated shops | shop2 | | ||
|
|
||
| Scenario: I assign product to categories they are the same on all shops, but default one can be different |
There was a problem hiding this comment.
hard to understand the scenario, wording could be improved
zuk3975
reviewed
Jan 27, 2023
| | id reference | name | is default | | ||
| | women | Women | true | | ||
| When I copy product product1 from shop shop2 to shop shop1 | ||
| # Women is not associated to shop1, so shop1's default category is used as default, thus it is also part of shop2's categories |
There was a problem hiding this comment.
not sure i get the comment idea, it is probably clear to yo, because you already know about this behavior
zuk3975
previously approved these changes
Jan 27, 2023
zuk3975
previously approved these changes
Jan 27, 2023
FabienPapet
reviewed
Jan 27, 2023
src/PrestaShopBundle/Resources/config/services/adapter/product.yml
Outdated
Show resolved
Hide resolved
FabienPapet
approved these changes
Jan 27, 2023
zuk3975
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is blocking for the
DuplicateProductCommandin multishop mode