New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional tests - Add new test 'Add to cart by quick view modal' #31426
Merged
boubkerbribri
merged 3 commits into
PrestaShop:8.1.x
from
nesrineabdmouleh:functionalFOQuickViewAddToCart
Feb 23, 2023
Merged
Functional tests - Add new test 'Add to cart by quick view modal' #31426
boubkerbribri
merged 3 commits into
PrestaShop:8.1.x
from
nesrineabdmouleh:functionalFOQuickViewAddToCart
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nesrineabdmouleh
commented
Feb 17, 2023
•
edited
edited
Questions | Answers |
---|---|
Branch? | 8.1.x |
Description? | Add new test 'Add to cart by quick view modal' |
Type? | refacto |
Category? | TE |
BC breaks? | no |
Deprecations? | no |
How to test? | Nightly run => https://github.com/nesrineabdmouleh/testing_pr/actions/runs/4204742434 |
Fixed ticket? | no |
Related PRs | no |
Sponsor company |
Progi1984
reviewed
Feb 20, 2023
Progi1984
reviewed
Feb 20, 2023
Comment on lines
15
to
16
import cartPage from '@pages/FO/cart'; | ||
import searchResultsPage from '@pages/FO/searchResults'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
import cartPage from '@pages/FO/cart'; | |
import searchResultsPage from '@pages/FO/searchResults'; |
Progi1984
reviewed
Feb 20, 2023
tests/UI/campaigns/functional/FO/09_productPage/01_quickView/01_addToCart.ts
Show resolved
Hide resolved
Progi1984
reviewed
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small feedbacks :) And it's 👍
nesrineabdmouleh
force-pushed
the
functionalFOQuickViewAddToCart
branch
from
February 22, 2023 14:55
ce19700
to
c78f8f9
Compare
Progi1984
approved these changes
Feb 22, 2023
boubkerbribri
approved these changes
Feb 23, 2023
Thanks @nesrineabdmouleh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.