Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests - Add new test 'Add to cart by quick view modal' #31426

Merged

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Feb 17, 2023

Questions Answers
Branch? 8.1.x
Description? Add new test 'Add to cart by quick view modal'
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
How to test? Nightly run => https://github.com/nesrineabdmouleh/testing_pr/actions/runs/4204742434
Fixed ticket? no
Related PRs no
Sponsor company

@nesrineabdmouleh nesrineabdmouleh added TE Category: Tests E2E Tests labels Feb 17, 2023
@nesrineabdmouleh nesrineabdmouleh added this to the 8.1.0 milestone Feb 17, 2023
@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner February 17, 2023 14:36
@prestonBot prestonBot added the Refactoring Type: Refactoring label Feb 17, 2023
Comment on lines 15 to 16
import cartPage from '@pages/FO/cart';
import searchResultsPage from '@pages/FO/searchResults';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import cartPage from '@pages/FO/cart';
import searchResultsPage from '@pages/FO/searchResults';

Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feedbacks :) And it's 👍

@boubkerbribri boubkerbribri merged commit a2ed415 into PrestaShop:8.1.x Feb 23, 2023
@boubkerbribri
Copy link
Contributor

Thanks @nesrineabdmouleh

@boubkerbribri boubkerbribri added the QA ✔️ Status: check done, code approved label Feb 23, 2023
@nesrineabdmouleh nesrineabdmouleh deleted the functionalFOQuickViewAddToCart branch April 6, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests QA ✔️ Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants