Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sales value in customer grid list #31440

Merged
merged 1 commit into from Feb 20, 2023
Merged

Fix sales value in customer grid list #31440

merged 1 commit into from Feb 20, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Feb 18, 2023 •
edited

Questions Answers
Branch? develop
Description? In #31104, we fixed total sale value for some users in customer detail page - when the built in invoicing was disabled. I forgot to do it also in the customer grid - here we go.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? See below
Fixed ticket? #31157
Related PRs
Sponsor company
  1. Go to orders > invoices and disable built-in invoicing.
  2. Order something in front office, visit that order and set order status to Payment accepted (or any other status that considers the order as valid)
  3. Visit Customers section in backoffice.
  4. Without this PR, you will see 0,00 EUR 🔴 , with this PR, the value of the order. ✅

@Hlavtox Hlavtox requested a review from a team as a code owner February 18, 2023 16:44
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Feb 18, 2023
@Hlavtox Hlavtox mentioned this pull request Feb 18, 2023
Closed
2 tasks
@zuk3975 zuk3975 added this to the 9.0.0 milestone Feb 20, 2023
@zuk3975 zuk3975 added the Waiting for QA Status: action required, waiting for test feedback label Feb 20, 2023
@MhiriFaten MhiriFaten self-assigned this Feb 20, 2023
MhiriFaten
MhiriFaten approved these changes Feb 20, 2023
View reviewed changes
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

LGTM, automated tests are OK.
QA approved ✔️

@MhiriFaten MhiriFaten added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 20, 2023
@kpodemski kpodemski merged commit 7606338 into PrestaShop:develop Feb 20, 2023
@kpodemski
Copy link
Contributor

thank you @Hlavtox :)

@lim3ra lim3ra mentioned this pull request Feb 20, 2023
Merged
@Hlavtox Hlavtox deleted the customer-grid-sales branch February 21, 2023 13:27
@Hlavtox Hlavtox mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@zuk3975 zuk3975 zuk3975 approved these changes

@MhiriFaten MhiriFaten MhiriFaten approved these changes

Assignees

@MhiriFaten MhiriFaten

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Hlavtox @kpodemski @zuk3975 @MhiriFaten @prestonBot