Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate attribute group edit #31502

Merged
merged 42 commits into from
Sep 19, 2023
Merged

Migrate attribute group edit #31502

merged 42 commits into from
Sep 19, 2023

Commits on Sep 11, 2023

  1. creating attribute type

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b93d40b View commit details
    Browse the repository at this point in the history

  2. Reverting package-lock.json

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a5cf1c0 View commit details
    Browse the repository at this point in the history

  3. Reverting package-lock.json

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    07f6d2e View commit details
    Browse the repository at this point in the history

  4. Adding behat tests

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6884659 View commit details
    Browse the repository at this point in the history

  5. Removed unneeded AttributeType.php

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    fff3f77 View commit details
    Browse the repository at this point in the history

  6. Fixed form type

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a4cff18 View commit details
    Browse the repository at this point in the history

  7. PHP stan fixes

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ddad352 View commit details
    Browse the repository at this point in the history

  8. Fixed template

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d82bfa2 View commit details
    Browse the repository at this point in the history

  9. CS fixer fix

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    52abd99 View commit details
    Browse the repository at this point in the history

  10. Added attribute group type for validation

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7bf4547 View commit details
    Browse the repository at this point in the history

  11. Changed to use repository in handlers

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    eb4caec View commit details
    Browse the repository at this point in the history

  12. Moved layout title to controller, changed EditAttributeGroupCommand.p… 

    …hp __construct to multiline
    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    cd1ba1d View commit details
    Browse the repository at this point in the history

  13. Update src/Core/Domain/AttributeGroup/ValueObject/AttributeGroupId.php 

    Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
    @JevgenijVisockij @jolelievre
    2 people authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    5c2cfe2 View commit details
    Browse the repository at this point in the history

  14. Snaller changes from code review

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    fc869ce View commit details
    Browse the repository at this point in the history

  15. Update src/PrestaShopBundle/Resources/config/services/core/form/form_… 

    …data_provider.yml


Adding public false to service

Co-authored-by: Julius Žukauskas <31609858+zuk3975@users.noreply.github.com>
    @JevgenijVisockij @zuk3975
    2 people authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f227cc8 View commit details
    Browse the repository at this point in the history

  16. Removed InvalidAttributeGroupIdException.php replacing iwth constrain… 

    …t exception and new param, smaller code review fixes
    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    56fd36c View commit details
    Browse the repository at this point in the history

  17. Changed attribute group to not use GetEditableAttribute group CQRS an… 

    …d use form data instead
    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ff04f69 View commit details
    Browse the repository at this point in the history

  18. Apply suggestions from code review 

    Smalled code review changes

Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
    @JevgenijVisockij @jolelievre
    2 people authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    95764b4 View commit details
    Browse the repository at this point in the history

  19. Update tests/Integration/Behaviour/Features/Context/Domain/AttributeG… 

    …roupFeatureContext.php


Removing default shop ids

Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
    @JevgenijVisockij @jolelievre
    2 people authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    210b72b View commit details
    Browse the repository at this point in the history

  20. Refactored behat tests to use multilantg

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    5c81b80 View commit details
    Browse the repository at this point in the history

  21. Refactored attribute group js to use 2 separate files

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f50a59f View commit details
    Browse the repository at this point in the history

  22. Apply suggestions from code review 

    Wording changes

Co-authored-by: l-delin <113511191+l-delin@users.noreply.github.com>
    @JevgenijVisockij @l-delin
    2 people authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c874ba6 View commit details
    Browse the repository at this point in the history

  23. Removed unneeded exception and smaller fixes

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6638569 View commit details
    Browse the repository at this point in the history

  24. Apply suggestions from code review 

    Changing exception messages back to attributes

Co-authored-by: l-delin <113511191+l-delin@users.noreply.github.com>
    @JevgenijVisockij @l-delin
    2 people authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f5ae785 View commit details
    Browse the repository at this point in the history

  25. Cleaned up attribute group exceptions

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b7573f1 View commit details
    Browse the repository at this point in the history

  26. Cleaned up attribute group exceptions

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d664958 View commit details
    Browse the repository at this point in the history

  27. CS fixer fix

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    bff2679 View commit details
    Browse the repository at this point in the history

  28. Updated phpdoc for AttributeGroupFeatureContext.php

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c1af84c View commit details
    Browse the repository at this point in the history

  29. Update tests/Integration/Behaviour/Features/Context/Domain/AttributeG… 

    …roupFeatureContext.php


Updated array definition in docs

Co-authored-by: Julius Žukauskas <31609858+zuk3975@users.noreply.github.com>
    @JevgenijVisockij @zuk3975
    2 people authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    594c6cc View commit details
    Browse the repository at this point in the history

  30. PHP stan fix

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b85cdbb View commit details
    Browse the repository at this point in the history

  31. Apply suggestions from code review 

    Code review changes

Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
    @JevgenijVisockij @jolelievre
    2 people authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    840a17b View commit details
    Browse the repository at this point in the history

  32. Code review fixes

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7fa4f83 View commit details
    Browse the repository at this point in the history

  33. Apply suggestions from code review 

    Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
    @JevgenijVisockij @jolelievre
    2 people authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    46f6e78 View commit details
    Browse the repository at this point in the history

  34. Code review fixes

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d38a779 View commit details
    Browse the repository at this point in the history

  35. Fixed not working update and add commands

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c174a81 View commit details
    Browse the repository at this point in the history

  36. CS fixer fix

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    efb4588 View commit details
    Browse the repository at this point in the history

  37. CS Fixer fixes

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a36be2e View commit details
    Browse the repository at this point in the history

  38. Fixed multistore not working properly

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    8cdf3b6 View commit details
    Browse the repository at this point in the history

  39. Cs fixer fix

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2fc82fb View commit details
    Browse the repository at this point in the history

  40. Fixed some typos

    @JevgenijVisockij
    JevgenijVisockij authored and Matthieu Rolland committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    bd3f85c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Fix last issues + implement export

    Matthieu Rolland authored and Matthieu Rolland committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    d6be6ab View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Update src/PrestaShopBundle/Resources/config/services/bundle/form/for… 

    …m_type.yml

Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
    @matthieu-rolland @jolelievre
    matthieu-rolland and jolelievre committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    7aa5916 View commit details
    Browse the repository at this point in the history