Handle custom lock file during the cache clear and force module actions one by one

[jolelievre]

Questions	Answers
Branch?	8.0.x
Description?	Handle custom lock file during the cache clear to make sure other processes have to wait until the new container is ready This is an alternative to the solution proposed in this PR #31419
Type?	bug fix
Category?	BO
BC breaks?	no
Deprecations?	yes
How to test?	The lock happens when Symfony cache is clear, mainly during any module operation (enable, disable, install, uninstall, ...) During the cache clearing, any other process (from a different tab) should be blocked until the cache is available again. We need to make sure that the shop doesn't end up in a blocked state for some reason, and we also should probably test that this doesn't impact the auto-upgrade process It could also be interesting to check that the use case related to this PR #30962 is still valid as it was also a complex use case related to cache clearing The module management has also been modified, now the bulk actions are forced one by one and when you try to perform two actions at the same time (by clicking on a button for a module while an action is in progress on another) the action is blocked and a warning message warns you that you need to wait
Fixed ticket?	Fixes #31562 and Fixes #28304
Related PRs	~
Sponsor company	~

[jolelievre]

(Edit 20/03 3h30pm) Running campaign https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/4469351523

[GautierBoudeweel]

If you call exit() within one registered shutdown function, processing will stop completely and no other registered shutdown functions will be called.
https://www.php.net/manual/en/function.register-shutdown-function.php

What if some code tied to actionClearSf2Cache hook executes an exit() call ? Maybe we could have a max_locking_time as a fallback ?

[jolelievre]

Do you mean having a timeout after which the file is unlocked? There is no such feature with flock as far as I know.

But anyway even if the file is not unlocked manually it will be automatically unlocked after the process that locked it ends, so if indeed someone calls exit in actionClearSf2Cache even though they SHOULD NEVER DO IT then the file will be unlocked.

[matks]

Pragmatic enough for me for a patch 👍

[prestonBot]

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

• Admin.Modules.Notification
  • An action is already in progress please wait for it to finish.

(Note: this is an automated message, but answering it will reach a real human)

[mflasquin]

LGTM but as I understand we will clear the cache for all actions (if clear cache is finish on previous action) on modules ? Not only the last action ?

[jolelievre]

@mflasquin indeed the clear cache on the last step was an "optimization" because it cost a lot of time, but in the end, considering all the bugs related to cache clearing and the instability it can occur I don't think the small gain is worth the risk

[djoelleuch]

Hello @jolelievre ,
I have tested your PR and it's well fixed !
The automated tests are OK.
It's QA approved 🚀
thank you !

[nicosomb]

Thank you @jolelievre 🎉 and @djoelleuch !