Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak on suppliers filter #31866

Merged
merged 1 commit into from Mar 24, 2023
Merged

Fix memory leak on suppliers filter #31866

merged 1 commit into from Mar 24, 2023

Conversation

mflasquin
Copy link
Contributor

@mflasquin mflasquin commented Mar 21, 2023 •
edited

Questions Answers
Branch? 8.1.x
Description? Fix the filter by Supplier by supplier do not work, it crashes the whole page after clicking on it
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? See #31248
Fixed ticket? Fixes #31248
Related PRs -
Sponsor company Prestashop SA

@mflasquin mflasquin requested a review from a team as a code owner March 21, 2023 15:36
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Mar 21, 2023
@mflasquin mflasquin changed the base branch from develop to 8.1.x March 23, 2023 08:56
@mflasquin mflasquin requested a review from a team as a code owner March 23, 2023 08:56
@mflasquin mflasquin changed the base branch from 8.1.x to develop March 23, 2023 08:56
@mflasquin mflasquin changed the base branch from develop to 8.1.x March 23, 2023 08:58
@mflasquin mflasquin closed this Mar 23, 2023
@mflasquin mflasquin reopened this Mar 23, 2023
@kpodemski kpodemski added the Waiting for QA Status: action required, waiting for test feedback label Mar 24, 2023
@AureRita AureRita self-assigned this Mar 24, 2023
@mflasquin mflasquin added this to the 8.1.0 milestone Mar 24, 2023
AureRita
AureRita approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mflasquin

Thank for your report ! I tested your PR and as you can see, this PR works :

Untitled_.Mar.24.2023.11_48.AM.webm

I see some issue but it's not on the scope of this PR.

test auto is green so it's QA approved ✔️

@AureRita AureRita added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 24, 2023
@AureRita AureRita removed their assignment Mar 24, 2023
@SharakPL SharakPL merged commit 0c4bd80 into PrestaShop:8.1.x Mar 24, 2023
38 checks passed
@SharakPL
Copy link
Contributor

Thank you @mflasquin & @AureRita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@kpodemski kpodemski kpodemski approved these changes

@AureRita AureRita AureRita approved these changes

Assignees
No one assigned
Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

BO - Stocks - The filter by Supplier by supplier do not work, it crashes the whole page after clicking on it
6 participants
@mflasquin @SharakPL @matthieu-rolland @kpodemski @AureRita @prestonBot