Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CVE 2023-25170 on 1.7.8.x #32140

Merged
merged 1 commit into from Apr 13, 2023
Merged

Fix CVE 2023-25170 on 1.7.8.x #32140

merged 1 commit into from Apr 13, 2023

Conversation

mflasquin
Copy link
Contributor

Questions Answers
Branch? 1.7.8.x
Description? Fix Security/CVE 2023 25170
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? login / logout clear csrf session tokens
Fixed ticket? -
Related PRs GHSA-3g43-x7qr-96ph
Sponsor company Prestashop SA

@mflasquin mflasquin requested a review from a team as a code owner April 12, 2023 18:50
@prestonBot prestonBot added 1.7.8.x Branch Improvement Type: Improvement labels Apr 12, 2023
jolelievre
jolelievre approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mflasquin

PululuK
PululuK approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@PululuK PululuK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mflasquin

@mflasquin mflasquin added the Waiting for QA Status: action required, waiting for test feedback label Apr 13, 2023
@mflasquin
Copy link
Contributor Author

I launched the tests locally since the CI is broken:

  • integration tests: OK
  • behaviour tests: OK
  • phpunit-legacy tests: OK
  • phpunit-endpoints tests: OK
  • unit-tests tests: OK
  • phpunit-sf tests: OK
  • phpunit-controllers: OK
  • phpunit-admin: OK

@mflasquin mflasquin merged commit 82cebe6 into PrestaShop:1.7.8.x Apr 13, 2023
19 of 31 checks passed
@mflasquin mflasquin added this to the 1.7.8.9 milestone Apr 13, 2023
@PululuK PululuK removed the Waiting for QA Status: action required, waiting for test feedback label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolelievre jolelievre jolelievre approved these changes

@PululuK PululuK PululuK approved these changes

Assignees
No one assigned
Labels
1.7.8.x Branch Improvement Type: Improvement
Projects
PR Dashboard
Archived in project
Milestone
1.7.8.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mflasquin @jolelievre @PululuK @prestonBot