Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating attribute value page #32475

Merged
merged 45 commits into from Feb 5, 2024
Merged

Migrating attribute value page #32475

merged 45 commits into from Feb 5, 2024

Commits on Feb 5, 2024

  1. Migrated view attribute

    @JevgenijVisockij @jolelievre
    JevgenijVisockij authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8b574c0 View commit details
    Browse the repository at this point in the history

  2. Updated behat tests

    @JevgenijVisockij @jolelievre
    JevgenijVisockij authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    187fd3f View commit details
    Browse the repository at this point in the history

  3. Fixing tests

    @JevgenijVisockij @jolelievre
    JevgenijVisockij authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    3f680a0 View commit details
    Browse the repository at this point in the history

  4. Add missing attribute on comand and query

    @jolelievre
    lartist authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    7edc5ac View commit details
    Browse the repository at this point in the history

  5. Fix phpstan

    @jolelievre
    lartist authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    b99ad94 View commit details
    Browse the repository at this point in the history

  6. Add missing configuration on Handlers

    @jolelievre
    lartist authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    415b81f View commit details
    Browse the repository at this point in the history

  7. fix attribute value add process when there is not color field

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    b5675ad View commit details
    Browse the repository at this point in the history

  8. add grid definition for attribute value

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    dd82df6 View commit details
    Browse the repository at this point in the history

  9. add attribute value export action and related route

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    29097d4 View commit details
    Browse the repository at this point in the history

  10. feedback and improvement

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    99c3a40 View commit details
    Browse the repository at this point in the history

  11. use scalar only in EdditableAttribute query result class

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    5daae31 View commit details
    Browse the repository at this point in the history

  12. more feedbacks fixes

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    c3927dd View commit details
    Browse the repository at this point in the history

  13. fix wrong phpdoc

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    ce74beb View commit details
    Browse the repository at this point in the history

  14. fix behat tests after rebase and feedback modifications

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    66b9db6 View commit details
    Browse the repository at this point in the history

  15. few feedbacks

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    0254034 View commit details
    Browse the repository at this point in the history

  16. rename param

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    ff489a6 View commit details
    Browse the repository at this point in the history

  17. refactor attribute validation

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    1f6bbc6 View commit details
    Browse the repository at this point in the history

  18. enable partial update on attribute edition for API

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    84c22f5 View commit details
    Browse the repository at this point in the history

  19. inject ShopContext and LanguageContext instead of raw IDs

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    25942e9 View commit details
    Browse the repository at this point in the history

  20. pass attribute_group to form type as an option instead of data

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    0ad180b View commit details
    Browse the repository at this point in the history

  21. Fix last review feedbacks

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    06655cb View commit details
    Browse the repository at this point in the history

  22. set proper service definitions for attribute form builder and handler

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9ab8d8f View commit details
    Browse the repository at this point in the history

  23. refactor attribute repositories and handlers as well as related valid… 

    …ator
    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    27206df View commit details
    Browse the repository at this point in the history

  24. select current attribute group as default in attribute form

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    cb40fa7 View commit details
    Browse the repository at this point in the history

  25. fix shop association

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    934c978 View commit details
    Browse the repository at this point in the history

  26. make behat tests congruents with attribute create/edit refactors

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6dbdbb8 View commit details
    Browse the repository at this point in the history

  27. add shop assocition tests for attribute creation and update

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6681348 View commit details
    Browse the repository at this point in the history

  28. add invalid color behat test

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    55fad31 View commit details
    Browse the repository at this point in the history

  29. rename accesors, setters and properties for attribute names

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6fb011a View commit details
    Browse the repository at this point in the history

  30. Update tests/Integration/Behaviour/Features/Context/Domain/AttributeF… 

    …eatureContext.php

Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
    @matthieu-rolland @jolelievre
    matthieu-rolland and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    cc16015 View commit details
    Browse the repository at this point in the history

  31. fix bugs related to name/value refactor

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    049d89e View commit details
    Browse the repository at this point in the history

  32. put back attribute group in behat config file

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    dafc527 View commit details
    Browse the repository at this point in the history

  33. check invalid color exception

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    32542c8 View commit details
    Browse the repository at this point in the history

  34. remove update method from AttributeRepository (partial update exists)

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    143ef64 View commit details
    Browse the repository at this point in the history

  35. remove final and don't extend AbstractObjectModelHandler in AddAttrib… 

    …uteHandler
    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a63f550 View commit details
    Browse the repository at this point in the history

  36. Update src/Adapter/Attribute/CommandHandler/AddAttributeHandler.php 

    Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
    @matthieu-rolland @jolelievre
    matthieu-rolland and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    e91cc7b View commit details
    Browse the repository at this point in the history

  37. use property promotion in attribute edit handler and validator

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    d9908e3 View commit details
    Browse the repository at this point in the history

  38. fix lang related behat bugs

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6df6ed8 View commit details
    Browse the repository at this point in the history

  39. cs fixer

    @jolelievre
    Matthieu Rolland authored and jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    618852d View commit details
    Browse the repository at this point in the history

  40. Handle attribute partial update tests in behat

    @jolelievre
    jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    f6d93e6 View commit details
    Browse the repository at this point in the history

  41. Correctly rename all value fields into name

    @jolelievre
    jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    1cab0e0 View commit details
    Browse the repository at this point in the history

  42. Improve attribute groups command handles to be more consistent with t… 

    …he others and handle partial update and better validation
    @jolelievre
    jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    efea104 View commit details
    Browse the repository at this point in the history

  43. Improve shop context building, it inclides associated shopIds now, an… 

    …d redirection to All shops context has been fixed
    @jolelievre
    jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    056cd41 View commit details
    Browse the repository at this point in the history

  44. Update integration of attribute and attribute group form to better ha… 

    …ndle multishop association field
    @jolelievre
    jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    469a69b View commit details
    Browse the repository at this point in the history

  45. Update CSV export column name

    @jolelievre
    jolelievre committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    68ab72a View commit details
    Browse the repository at this point in the history