Remove module list item when force deletion

[M0rgan01]

Questions	Answers
Branch?	develop
Description?	When deleting a module, we can dynamically remove the module from the list, or force the reload of the page. I chose to do it dynamically in JS for user experience. We do not remove the module from the list if it has a download url, to be able to re-download it if necessary I also modified the behavior of the dropdowns for the buttons after uninstallation, in fact it was possible to delete a module that was already deleted
Type?	bug fix
Category?	BO
BC breaks?	no
Deprecations?	no
How to test?	see #30952
Fixed ticket?	Fixes #30952
Related PRs	-
Sponsor company	-

Attention, for the modifications to work correctly, the url of the distribution API must be modified for the purposes of the tests. Indeed the recovery of the list of modules for 8.1.x is not yet possible. See https://api.prestashop-project.org/prestashop for versions and modify the PrestaShop/modules/ps_distributionapiclient/src/DistributionApi.php file

[boherm]

LGTM, after ESLint fix!
Just one question for .hide() instead of .remove(). 😄

[boherm]

I'm not blocking for this, but why not use .remove() instead?

[M0rgan01]

I agree, remove is better

[M0rgan01]

The transition from hide to remove required a small additional tweak. You have to send the event before removing.
( this.eventEmitter.emit('Module Uninstalled', mainElement);)

Now it is good 😄

[Hlavtox]

We should not be hardcoding a module name in the core, other distributions can have a different marketplace.

Also, we should check if this module is available from an API before removing it from the list, because it will reappear after refresh. 👍

[AchrafKchaou1991]

Hello @M0rgan01
It seems the issue still persist, see the attached screen record below:

Pr32662.webm

Waiting for your feedback.
Thanks!

[matks]

@hibatallahAouadni It is important to be aware that the behavior for a development branch and the behavior for a live version are not the same.

If you are on a live version, let's say you use 8.0.4

If you uninstall the module pagenotfound and you choose to delete the files from the disk then the module is not available anymore in your modules/ folder. However PrestaShop is able to poll the API endpoint https://api.prestashop-project.org/modules/8.0.4 and to find it. Then PrestaShop is able to display a "Install" button, because it is capable of retrieving the module from the API.

If you are on a live version, let's say you use develop branch -> it means version is 9.0.0

There is no endpoint https://api.prestashop-project.org/modules/9.0.0

If you uninstall the module pagenotfound and you choose to delete the files from the disk then the module is not available anymore in your modules/ folder. And PrestaShop is NOT able to poll the API endpoint https://api.prestashop-project.org/modules/9.0.0 to find it. Then PrestaShop is NOT able to display a "Install" button for pagenotfound module, because it is not capable of retrieving the module from the API. So the pagenotfound module is not shown in the modules list, and it is the expected behavior

[M0rgan01]

@Hlavtox I propose a new version of my PR :)

[tleon]

LGTM, I'm not the best at js / ts would be great if others could have a look.

[aniszr]

Hello @M0rgan01

Thanks for your PR,the module display issue is solved.LGTM ✔️

See attached screenvideo:

Module.manager.testAniss.mp4

Thanks!

[prestonBot]

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

not relevant anymore

[kpodemski]

thank you @M0rgan01