Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added www-authenticate: bearer if the access token is invalid #32885

Merged
merged 3 commits into from Jul 27, 2023
Merged

Added www-authenticate: bearer if the access token is invalid #32885

merged 3 commits into from Jul 27, 2023

Conversation

nicosomb
Copy link
Contributor

Questions Answers
Branch? 8.1.x
Description? Returns a header WWW-Authenticate : Bearer if the access token is invalid
Type? bug fix
Category? WS
BC breaks? no
Deprecations? no
How to test? #32882
Fixed ticket? Fixes #32882
Related PRs ~
Sponsor company PrestaShop SA

@nicosomb nicosomb requested a review from a team as a code owner June 12, 2023 12:51
@prestonBot prestonBot added the Bug fix Type: Bug fix label Jun 12, 2023
@nicosomb nicosomb linked an issue Jun 12, 2023 that may be closed by this pull request
API : External Auth Server : Returns (not) a header WWW-Authenticate : Bearer if the access token is invalid #32882
Closed
2 tasks
@nicosomb nicosomb requested a review from a team as a code owner June 12, 2023 13:00
@nicosomb
Copy link
Contributor Author

Tests https://github.com/nicosomb/ga.tests.ui.pr/actions/runs/5243891797

mflasquin
mflasquin previously approved these changes Jun 12, 2023
View reviewed changes
Progi1984
Progi1984 requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is 🔴

@ps-jarvis ps-jarvis added the Waiting for author Status: action required, waiting for author feedback label Jun 12, 2023
jolelievre
jolelievre previously approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nicosomb

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jun 13, 2023
M0rgan01
M0rgan01 previously approved these changes Jun 14, 2023
View reviewed changes
@nicosomb nicosomb dismissed stale reviews from jolelievre and mflasquin via 8c4c173 June 15, 2023 14:52
boherm
boherm previously approved these changes Jun 15, 2023
View reviewed changes
@prestashop-issue-bot prestashop-issue-bot bot removed the Waiting for author Status: action required, waiting for author feedback label Jun 15, 2023
@nicosomb
Copy link
Contributor Author

Test https://github.com/nicosomb/ga.tests.ui.pr/actions/runs/5280636880

@djoelleuch
Copy link

Hello @nicosomb ,
some checks were not successful , could you please check it .

@djoelleuch djoelleuch added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 15, 2023
@nicosomb nicosomb force-pushed the fix-32882 branch 2 times, most recently from 0e3c5a5 to e480bfb Compare July 10, 2023 07:16
@Progi1984
Copy link
Contributor

UI Test : https://github.com/Progi1984/ga.tests.ui.pr/actions/runs/5517067057

@nicosomb @Progi1984
Update tests/UI/campaigns/functional/API/01_clientCredentialGrantFlow…
2c8e31e 
…/02_externalAuthServer/02_resourceEndpoint.ts

Co-authored-by: Progi1984 <progi1984@gmail.com>
@nicosomb
Copy link
Contributor Author

UI tests https://github.com/nicosomb/ga.tests.ui.pr/actions/runs/5643118513

@nicosomb nicosomb removed the Waiting for author Status: action required, waiting for author feedback label Jul 24, 2023
Progi1984
Progi1984 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for UI tests (Unskip the test as defined in Acceptance Test and UI tests are 🟢)

Ping @PrestaShop/ui-tests-maintainers

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jul 24, 2023
@Progi1984 Progi1984 modified the milestones: 8.1.1, 8.1.2 Jul 24, 2023
@Hlavtox Hlavtox added the 8.1.x Branch label Jul 26, 2023
@djoelleuch djoelleuch self-assigned this Jul 27, 2023
djoelleuch
djoelleuch approved these changes Jul 27, 2023
View reviewed changes
Copy link

@djoelleuch djoelleuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nicosomb ,

I have tested your PR and it's well fixed !

Untitled_.Jul.27.2023.1_57.PM.webm

automated tests : OK
It's QA approved ✔️
Thank you 🚀

@djoelleuch djoelleuch added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 27, 2023
@Progi1984
Copy link
Contributor

Congrats @nicosomb : Never give up ;)

@matthieu-rolland
Copy link
Contributor

thank you @nicosomb and @djoelleuch

@matthieu-rolland matthieu-rolland merged commit a7c41d5 into PrestaShop:8.1.x Jul 27, 2023
41 checks passed
@nicosomb nicosomb deleted the fix-32882 branch November 6, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@mflasquin mflasquin mflasquin approved these changes

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@djoelleuch djoelleuch djoelleuch approved these changes

@jolelievre jolelievre jolelievre left review comments

@boherm boherm boherm left review comments

Assignees

@djoelleuch djoelleuch

Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.2
Development

Successfully merging this pull request may close these issues.

API : External Auth Server : Returns (not) a header WWW-Authenticate : Bearer if the access token is invalid